Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: removed median percentile to be always included in describe GH #60550 #60557

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+35 −7
Open

ENH: removed median percentile to be always included in describe GH #60550 #60557

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
05709ef
ENH: removed median percentile to be always included in describe
ZenithClown Dec 13, 2024
5c745f3
skip validation for blank list, return median percentile
ZenithClown Dec 14, 2024
7264ee6
add enhancement changelog for gh#60550
ZenithClown Dec 14, 2024
2552f9a
Merge branch 'main' into patch-gh#60550
ZenithClown Dec 14, 2024
3e08684
DOC: add the default median behavior in function docstring
ZenithClown Dec 14, 2024
c1c1879
add test cases for percentile refine for describe function
ZenithClown Dec 18, 2024
dd875da
use pytest mark parametrize to fix input and expected values
ZenithClown Dec 18, 2024
98a0143
Fix typo in docstring, add space
ZenithClown Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pandas/core/methods/describe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,13 @@ def _refine_percentiles(
# explicit conversion of `percentiles` to list
percentiles = list(percentiles)

# median should be included only if blank list is passed
if len(percentiles) == 0:
percentiles.append(0.5)
ZenithClown marked this conversation as resolved.
Show resolved Hide resolved

# get them all to be in [0, 1]
validate_percentile(percentiles)

# median should always be included
if 0.5 not in percentiles:
percentiles.append(0.5)

percentiles = np.asarray(percentiles)

# sort and check for duplicates
Expand Down
Loading