BUG: ValueError when printing a DataFrame with DataFrame in its attrs #60459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b48fc35.
This reverts commit 6b45ac5.
Contributor
Author
|
Hmm, I don't understand why there is a mypy error after this change: I don't get this error locally. |
mroeschke
requested changes
Dec 2, 2024
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Looks good. Could you add a whatsnew entry in v3.0.0.rst?
mroeschke
added
Output-Formatting
Contributor
Author
Not sure where the right place is, I added in the |
mroeschke
approved these changes
Dec 3, 2024
Member
|
Thanks @yuanx749 |
|
Many thanks @yuanx749 |
3 tasks
5 tasks
KevsterAmp
pushed a commit
to KevsterAmp/pandas
that referenced
this pull request
Mar 12, 2025
…pandas-dev#60459) * Add test * replace concat with np * Revert "replace concat with np" This reverts commit b48fc35. * Revert "Revert "replace concat with np"" This reverts commit 6b45ac5. * try fixing mypy error * Add whatsnew --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR replaces
concatwith slice in_truncate_horizontallyas in_truncate_verticallyto avoid the ValueError.pandas/pandas/io/formats/format.py
Lines 697 to 699 in a4fc97e