Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new parameter to value_counts to keep both counts and normalized values. #60335

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Keramatfar
Copy link

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • [*] Tests added and passed if fixing a bug or adding a new feature
  • [*] All code checks passed.
  • [*] Added type annotations to new arguments/methods/functions.
  • [*] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm negative on returning numeric data as strings. I'm also negative on adding a keyword to this function. I suggest you open up an issue to request this feature and have discussion take place there.

@rhshadrach rhshadrach added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Enhancement labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants