Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP/COMPAT: don't use Literal for Series.ndim to avoid tab completion bug in IPython #60197

Merged
merged 1 commit into from
Nov 5, 2024
Merged

TYP/COMPAT: don't use Literal for Series.ndim to avoid tab completion bug in IPython #60197

merged 1 commit into from
Nov 5, 2024

Conversation

jorisvandenbossche
Copy link
Member

Not entirely sure if it is up to us to "fix" this, but given this has not been fixed upstream for several months, and it is quite annoying that tab completion doesn't work in IPython by default, this might be an easy win short-term (with only a minor decrease in correctness of the type annoations)

xref ipython/ipython#14412, davidhalter/jedi#1990

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jorisvandenbossche jorisvandenbossche added Compat pandas objects compatability with Numpy or Python functions Upstream issue Issue related to pandas dependency labels Nov 5, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 5, 2024
@mroeschke mroeschke merged commit e449b49 into pandas-dev:main Nov 5, 2024
54 of 55 checks passed
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Nov 5, 2024
@jorisvandenbossche @meeseeksmachine
Backport PR pandas-dev#60197: TYP/COMPAT: don't use Literal for Serie…
92232a1 
…s.ndim to avoid tab completion bug in IPython
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 5, 2024
Merged
@jorisvandenbossche jorisvandenbossche deleted the fix-ipython-completion branch November 5, 2024 20:00
jorisvandenbossche added a commit that referenced this pull request Nov 5, 2024
@meeseeksmachine @jorisvandenbossche
Backport PR #60197 on branch 2.3.x (TYP/COMPAT: don't use Literal for…
92a0c81 
… Series.ndim to avoid tab completion bug in IPython) (#60200)

Backport PR #60197: TYP/COMPAT: don't use Literal for Series.ndim to avoid tab completion bug in IPython

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Upstream issue Issue related to pandas dependency
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @mroeschke