-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docstring Timedelta.to_timedelta64 SA01, Timedelta.total_seconds SA01, Timedelta.view SA01 #59719
Conversation
@mroeschke should this PR be closed? cf #59698 |
I think this PR can continue. I think the methods you're addressing are not resolved on main |
is there anything else I should do? |
Please view the failing CI checks. The logs should provide details of the error |
yup - this is the test failure you should focus on:
if you can get that test passing, this can progress |
@MarcoGorelli need anything else on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @fbourgey - i think if you fetch and merge upstream/main then it should be good
Thanks @fbourgey |
Issue #59698
Solved the following