Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: CategoricalDtype.update_dtype #59647

Merged
merged 5 commits into from
Sep 5, 2024
Merged

PERF: CategoricalDtype.update_dtype #59647

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
866d94f
PERF: CategoricalDtype.update_dtype
mroeschke Aug 28, 2024
f98f17e
Add whatsnew number add comment
mroeschke Aug 28, 2024
4302ea0
Fix unit test
mroeschke Aug 28, 2024
d712505
Merge remote-tracking branch 'upstream/main' into perf/categoricaldty…
mroeschke Aug 30, 2024
a119f6e
short circut only for the dtype
mroeschke Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit test
  • Loading branch information
@mroeschke
mroeschke committed Aug 28, 2024
commit 4302ea015ecd6fcb67a188dfd3ab0a4a232024f2
4 changes: 3 additions & 1 deletion pandas/tests/dtypes/test_dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ def test_repr_range_categories(self):

def test_update_dtype(self):
# GH 27338
result = CategoricalDtype(["a"]).update_dtype(Categorical(["b"], ordered=True))
result = CategoricalDtype(["a"]).update_dtype(
CategoricalDtype(["b"], ordered=True)
)
expected = CategoricalDtype(["b"], ordered=True)
assert result == expected

Expand Down