TST (string dtype): Adjust indexing string tests #59541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
539
to
542
| if using_infer_string: | ||
| with pytest.raises(TypeError, match="Invalid value"): | ||
| df.iloc[:, 0] = df.iloc[:, 0].astype(np.int64) | ||
| else: |
There was a problem hiding this comment.
No idea if it is tested elsewhere, but we should also keep some tests where we assert that if you have object dtype and set with another dtype, that it preserves the object dtype. So alternatively, could also add dtype=object to the dataframe construction and for the rest keep the current test.
There was a problem hiding this comment.
Updated, but not sure if I like this any better tbh
jorisvandenbossche
approved these changes
Aug 20, 2024
jorisvandenbossche
changed the title
ammar-qazi
pushed a commit
to ammar-qazi/pandas
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Oct 10, 2024
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 10, 2024
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #54792