Skip to content

Conversation

Pranav-Wadhwa
Copy link
Contributor

@Pranav-Wadhwa Pranav-Wadhwa commented Aug 16, 2024

#58989

This PR is incomplete - getting feedback from maintainers

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

Given the comment in #58989 (comment) going to close

@mroeschke mroeschke closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants