Skip to content

String dtype: fix convert_dtypes() to convert NaN-string to NA-string #59470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2024
+18 −18
Merged

String dtype: fix convert_dtypes() to convert NaN-string to NA-string #59470

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9c5d20
String dtype: fix convert_dtypes() to convert NaN-string to NA-string
jorisvandenbossche Aug 10, 2024
40185d3
fix CoW tracking for conversion to python storage strings
jorisvandenbossche Aug 10, 2024
a843351
remove xfails
jorisvandenbossche Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix CoW tracking for conversion to python storage strings
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Aug 10, 2024
commit 40185d36c0bddb52af42f71ca186ff2fb8287efb
6 changes: 5 additions & 1 deletion pandas/core/internals/blocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,11 @@ def convert(self) -> list[Block]:
convert_non_numeric=True,
)
refs = None
if res_values is values:
if (
res_values is values
or isinstance(res_values, NumpyExtensionArray)
and res_values._ndarray is values
):
refs = self.refs

res_values = ensure_block_shape(res_values, self.ndim)
Expand Down
Loading