Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: Fix numpy 2.1 timedelta * DateOffset #59441

Merged
merged 1 commit into from
Aug 7, 2024
Merged

COMPAT: Fix numpy 2.1 timedelta * DateOffset #59441

merged 1 commit into from
Aug 7, 2024

Conversation

mroeschke
Copy link
Member

No description provided.

@mroeschke mroeschke added Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type Frequency DateOffsets Compat pandas objects compatability with Numpy or Python functions labels Aug 7, 2024
@mroeschke mroeschke modified the milestones: 3.0, 2.2.3 Aug 7, 2024
@mroeschke
Copy link
Member Author

Not sure if the change upstream in numpy is expected, but IMO the checks added are more explicit so I'd say this additional check is fine. Merging to get the CI to green

@mroeschke mroeschke merged commit d0cb205 into pandas-dev:main Aug 7, 2024
53 checks passed
@mroeschke mroeschke deleted the fix/compat/npdev branch August 7, 2024 20:49
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 7, 2024
@mroeschke @meeseeksmachine
Backport PR pandas-dev#59441: COMPAT: Fix numpy 2.1 timedelta * DateO…
7f2fd6b 
…ffset
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 7, 2024
Merged
mroeschke added a commit that referenced this pull request Aug 7, 2024
@meeseeksmachine @mroeschke
Backport PR #59441 on branch 2.2.x (COMPAT: Fix numpy 2.1 timedelta *…
795cce2 
… DateOffset) (#59444)

Backport PR #59441: COMPAT: Fix numpy 2.1 timedelta * DateOffset

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@mroeschke mroeschke mentioned this pull request Aug 30, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Frequency DateOffsets Numeric Operations Arithmetic, Comparison, and Logical operations Timedelta Timedelta data type
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
1 participant
@mroeschke