Skip to content

BUG: DataFrame.sparse.from_spmatrix hard codes an invalid fill_value for certain subtypes #59064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 27, 2024
Merged

BUG: DataFrame.sparse.from_spmatrix hard codes an invalid fill_value for certain subtypes #59064

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
cd922b6
BUG: :bug: :sparkles: Add fill_value param to from_spmatrix method.
christophertitchen Jun 20, 2024
9323e43
ENH: :sparkles: Set explicit fill_value of NaN for complex floats.
christophertitchen Jun 20, 2024
212a664
TST: :white_check_mark: Fix failing tests.
christophertitchen Jun 20, 2024
81b33f5
TST: :white_check_mark: Add tests for from_spmatrix method.
christophertitchen Jun 20, 2024
f5f1479
DOC: :memo: Add what's new entry.
christophertitchen Jun 21, 2024
57367aa
TST: :white_check_mark: Fix failing tests for sparse getitem.
christophertitchen Jun 21, 2024
e90963a
TST: :white_check_mark: Remove test for 256-bit complex float.
christophertitchen Jun 21, 2024
eb222a6
DOC: :memo: Update example in docstring for from_spmatrix method.
christophertitchen Jun 21, 2024
221c4aa
DOC: :memo: Update some docstrings and sparse user guide.
christophertitchen Jun 21, 2024
0d07c30
DOC: :pencil2: Update dtype docstring.
christophertitchen Jun 22, 2024
ccba29e
BUG: :rewind: :bug: Revert fill_value change and fix to_coo method.
christophertitchen Jun 27, 2024
d09171e
TST: :rewind: :white_check_mark: Fix and add sparse accessor tests.
christophertitchen Jun 27, 2024
b813453
TST: :rewind: :white_check_mark: Fix and add sparse getitem tests.
christophertitchen Jun 27, 2024
499db2f
DOC: :rewind: :memo: Revert fill_value change to sparse user guide.
christophertitchen Jun 27, 2024
9eb3dac
CLN: :pencil2: Fix instantiation of np.ma.array in test.
christophertitchen Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CLN: ✏️ Fix instantiation of np.ma.array in test.
  • Loading branch information
@christophertitchen
christophertitchen committed Jun 27, 2024
commit 9eb3dac4ed9d3dcbfb8e2bd130159e095d5f9eb5
2 changes: 1 addition & 1 deletion pandas/tests/arrays/sparse/test_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_from_spmatrix(self, format, labels, dtype):
result = pd.DataFrame.sparse.from_spmatrix(sp_mat, index=labels, columns=labels)
mat = np.eye(10, dtype=dtype)
expected = pd.DataFrame(
np.ma.masked_array(mat, mask=(mat == 0)).filled(sp_dtype.fill_value),
np.ma.array(mat, mask=(mat == 0)).filled(sp_dtype.fill_value),
index=labels,
columns=labels,
).astype(sp_dtype)
Expand Down
Loading