New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: don't silently drop Nones in concat #57847

Closed

twoertwein wants to merge 2 commits into pandas-dev:main from twoertwein:concat

Member

twoertwein commented Mar 14, 2024

closes Deprecate accepting None in pd.concat #57846 (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Might need a deprecation cycle? Or can we get away with this change in 3.0?

twoertwein added 2 commits

March 14, 2024 18:29


          DEPR: don't silently drop Nones in concat

6d2582c


          fails now

dfe5cf2

twoertwein marked this pull request as ready for review

March 15, 2024 02:34

phofl requested changes

View reviewed changes

Member

phofl left a comment

see #57846 (comment)

twoertwein closed this

twoertwein deleted the concat branch

April 7, 2024 10:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet