Use ruff to enforce import alias #57282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good. Could you address the pre-commit failure? |
tqa236
force-pushed
the
use-ruff-to-enforce-alias
branch
from
10e20b5 to
e75de8c
Compare
|
@mroeschke I fixed the config and removed the old hook. |
mroeschke
approved these changes
Mar 5, 2024
|
Thanks @tqa236 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Use ruff to enforce import alias * Remove old hook --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the hook
use-pd_array-in-corewithruff'sunconventional-import-aliasThe
pre-commitjob will fail to show that the check works. It will pass after I enableexclude: ^pandas/core/api\.py$.If this change is accepted, I can continue with removing the old hook.
As far as I can understand, a major difference is that
scripts/use_pd_array_in_core.pytries to detect all variants ofpd.<insert anything here>.arraywhile we must explicitly pass the full path forruff(there's onlypandas.core.construction.array).