Skip to content

check ExtensionType in is_datetime64_any_dtype for array-likes #57060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 2, 2024
Merged

check ExtensionType in is_datetime64_any_dtype for array-likes #57060

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
784ed81
check for ExtensionType in is_datetime64_any_dtype
jmoralez Jan 24, 2024
89655f4
use pre-commit
jmoralez Jan 24, 2024
e6b1789
add test and move doc entry
jmoralez Jan 25, 2024
3b85fe6
check not date in test
jmoralez Jan 25, 2024
623cd24
fix condition
jmoralez Jan 25, 2024
bbbb2fa
check type is not datetime.date
jmoralez Jan 25, 2024
c1aa674
fix comparison
jmoralez Jan 25, 2024
734bb03
move description to ExtensionArray
jmoralez Jan 31, 2024
178c062
return True for date types
jmoralez Jan 31, 2024
75ca218
Merge branch 'main' into check-extension-isdt64any
jmoralez Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v2.2.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Fixed regressions

Bug fixes
~~~~~~~~~
-
- Bug in :meth:`api.types.is_datetime64_any_dtype` where a custom :class:`ExtensionDtype` would not return ``True`` for array-likes (:issue:`57055`)

.. ---------------------------------------------------------------------------
.. _whatsnew_221.other:
Expand Down
6 changes: 5 additions & 1 deletion pandas/core/dtypes/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,11 @@ def is_datetime64_any_dtype(arr_or_dtype) -> bool:
tipo = _get_dtype(arr_or_dtype)
except TypeError:
return False
return lib.is_np_dtype(tipo, "M") or isinstance(tipo, DatetimeTZDtype)
return (
lib.is_np_dtype(tipo, "M")
or isinstance(tipo, DatetimeTZDtype)
or (isinstance(tipo, ExtensionDtype) and tipo.kind == "M")
)


def is_datetime64_ns_dtype(arr_or_dtype) -> bool:
Expand Down