Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: some return types from ruff #56617

Merged
merged 5 commits into from
Dec 26, 2023
Merged

TYP: some return types from ruff #56617

merged 5 commits into from
Dec 26, 2023

Conversation

twoertwein
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added this to the 2.2 milestone Dec 26, 2023
@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Dec 26, 2023
@mroeschke mroeschke merged commit 12d69c8 into pandas-dev:main Dec 26, 2023
54 checks passed
@mroeschke
Copy link
Member

Thanks @twoertwein

@meeseeksmachine meeseeksmachine mentioned this pull request Dec 26, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 26, 2023
@twoertwein @meeseeksmachine
Backport PR pandas-dev#56617: TYP: some return types from ruff
06c0081
lithomas1 pushed a commit that referenced this pull request Dec 26, 2023
@meeseeksmachine @twoertwein
Backport PR #56617 on branch 2.2.x (TYP: some return types from ruff) (…
18aa834 
…#56624)

Backport PR #56617: TYP: some return types from ruff

Co-authored-by: Torsten Wörtwein <twoertwein@users.noreply.github.com>
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
@twoertwein @cbpygit
TYP: some return types from ruff (pandas-dev#56617)
c5d1e6c 
* TYP: some return types from ruff

* fix CI

* and another one

* adjust pre-commit
@twoertwein twoertwein deleted the ruff_return branch January 17, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @mroeschke