DEPR: Remove SettingWithCopyWarning #56614

phofl · 2023-12-24T18:17:19Z

🥳

We shouldn't merge before the actual release is out

_item_cache removal
closes #50547
closes #29411
closes #21391

SettingWIthCopyWarning removal
closes #18752
closes #9767
closes #14150
closes #16550
closes #17505
closes #38270
closes #39418
closes #39448
closes #41891
closes #45513
closes #50209
closes #55451

Others Matt thinks
closes #19102

jreback · 2023-12-24T18:34:56Z

wow this kills giant hacks that i wrote from a while back!

+1000000

jreback · 2023-12-24T18:37:27Z

pandas/core/generic.py

-                "A value is trying to be set on a copy of a slice from a "
-                "DataFrame\n\n"
-                "See the caveats in the documentation: "
-                "https://pandas.pydata.org/pandas-docs/stable/user_guide/"


are these docs still there?

Yeah I’ll continue this pr later or
Tomorrow, the code things should be gone, docs not yet

# Conflicts: # pandas/tests/copy_view/test_indexing.py # pandas/tests/copy_view/test_internals.py # pandas/tests/copy_view/test_methods.py # pandas/tests/frame/indexing/test_xs.py # pandas/tests/indexing/multiindex/test_chaining_and_caching.py # pandas/tests/indexing/multiindex/test_setitem.py # pandas/tests/indexing/test_chaining_and_caching.py

github-actions · 2024-01-27T00:05:06Z

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

# Conflicts: # ci/code_checks.sh # pandas/core/generic.py # pandas/core/groupby/groupby.py # pandas/errors/__init__.py # pandas/tests/copy_view/test_chained_assignment_deprecation.py # pandas/tests/copy_view/test_indexing.py # pandas/tests/indexing/test_chaining_and_caching.py # pandas/tests/series/test_ufunc.py

mroeschke · 2024-02-02T00:59:20Z

doc/source/user_guide/advanced.rst

@@ -402,6 +395,7 @@ slicers on a single axis.
 Furthermore, you can *set* the values using the following methods.

 .. ipython:: python
+   :okwarning:


Is this the pdep warning? Best to just change this example or remove if it won't work anymore

doesn't seem to be necessary anymore, lets see what ci has to say

I'll keep this in for now, I can't reproduce locally but it shows up on ci, it's weird

mroeschke · 2024-02-02T01:00:29Z

doc/source/user_guide/indexing.rst

-   reported.
+:ref:`Copy-on-Write <copy_on_write>` is the new default with pandas 3.0.
+This means than chained indexing will never work. As a consequence,
+the ``SettingWithCopyWarning`` is not necessary anymore.


I would remove the As a consequence, the ``SettingWithCopyWarning`` is not necessary anymore. sentence since that warning will no longer exist

mroeschke · 2024-02-02T01:02:53Z

pandas/core/frame.py

@@ -4136,7 +4121,7 @@ def _get_value(self, index, col, takeable: bool = False) -> Scalar:
            series = self._ixs(col, axis=1)
            return series._values[index]

-        series = self._get_item_cache(col)
+        series = self[col]


self._get_item(col)?

hm yeah this should work, thx

mroeschke · 2024-02-02T01:04:03Z

pandas/core/generic.py

-        if len(self._mgr.blocks) != blocks_before:
-            self._clear_item_cache()
-        return result
+        return f()


I think we don't need _protect_consolidate anymore right?

good point, no

mroeschke · 2024-02-02T01:20:49Z

Could you see if this works?

#44866

mroeschke · 2024-02-02T02:40:17Z

doc/source/reference/testing.rst

@@ -58,8 +58,6 @@ Exceptions and warnings
   errors.PossiblePrecisionLoss
   errors.PyperclipException
   errors.PyperclipWindowsException
-   errors.SettingWithCopyError


If you have another PR with the whatsnew note, please make sure that the removal of these are mentioned

I'll create a separate PR with a whatsnew

# Conflicts: # doc/source/user_guide/indexing.rst

phofl · 2024-02-03T22:46:08Z

Could you see if this works?

#44866

It works if you use it on a series but it will never work if you do

df["a"].foo = "something
df["a"].foo

because both df["a"] are different objects with CoW, so this can't work

We can close the issue though, the case doesn't make sense under CoW

mroeschke

Feel free to merge once you fix the merge conflict

# Conflicts: # pandas/_config/__init__.py # pandas/core/frame.py # pandas/core/generic.py # pandas/core/series.py # pandas/tests/copy_view/test_chained_assignment_deprecation.py # pandas/tests/copy_view/test_indexing.py # pandas/tests/copy_view/test_interp_fillna.py # pandas/tests/copy_view/test_methods.py # pandas/tests/copy_view/test_replace.py # pandas/tests/frame/indexing/test_indexing.py # pandas/tests/frame/indexing/test_xs.py # pandas/tests/indexing/multiindex/test_chaining_and_caching.py # pandas/tests/indexing/multiindex/test_setitem.py # pandas/tests/indexing/test_chaining_and_caching.py # pandas/tests/series/accessors/test_dt_accessor.py

bersbersbers · 2024-02-05T07:50:33Z

This PR closed an issue I subscribed to (#9767), and I had no idea why and how until I found https://pandas.pydata.org/pdeps/0007-copy-on-write.html. Leaving this here for others.

* DEPR: Remove SettingWithCopyWarning * Fixup * Remove docs * CoW: Boolean indexer in MultiIndex raising read-only error * Update * Update * Update

DEPR: Remove SettingWithCopyWarning

b2183ba

phofl requested a review from rhshadrach as a code owner December 24, 2023 18:17

phofl marked this pull request as draft December 24, 2023 18:17

jreback reviewed Dec 24, 2023

View reviewed changes

phofl and others added 6 commits December 25, 2023 02:10

Fixup

53c3f76

Remove docs

a0ddaa1

Merge remote-tracking branch 'upstream/main' into settingwithcopywarning

8e29d0d

CoW: Boolean indexer in MultiIndex raising read-only error

7929800

Merge branch 'cow_read_only' into settingwithcopywarning

8ef42d7

github-actions bot added the Stale label Jan 27, 2024

phofl removed the Stale label Feb 1, 2024

phofl marked this pull request as ready for review February 1, 2024 22:29

phofl added this to the 3.0 milestone Feb 2, 2024

phofl added the Copy / view semantics label Feb 2, 2024

mroeschke reviewed Feb 2, 2024

View reviewed changes

phofl added 2 commits February 3, 2024 22:40

Update

60653ad

Merge remote-tracking branch 'upstream/main' into settingwithcopywarning

62385bf

# Conflicts: # doc/source/user_guide/indexing.rst

Update

00cb5ff

mroeschke approved these changes Feb 4, 2024

View reviewed changes

Update

516bd88

phofl merged commit bc58fe5 into pandas-dev:main Feb 4, 2024
46 of 47 checks passed

phofl deleted the settingwithcopywarning branch February 4, 2024 15:18

simonjayhawkins mentioned this pull request May 14, 2024

BUG: ChainedAssignmentError link to documentation will break? #58716

Closed

3 tasks

krassowski mentioned this pull request Sep 4, 2024

Improve pandas dataframe inspection jupyterlab-contrib/jupyterlab-variableInspector#319

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPR: Remove SettingWithCopyWarning #56614

DEPR: Remove SettingWithCopyWarning #56614

phofl commented Dec 24, 2023 •

edited by mroeschke

Loading

jreback commented Dec 24, 2023

jreback Dec 24, 2023

phofl Dec 24, 2023

github-actions bot commented Jan 27, 2024

mroeschke Feb 2, 2024

phofl Feb 3, 2024

phofl Feb 4, 2024

mroeschke Feb 2, 2024

phofl Feb 3, 2024

mroeschke Feb 2, 2024

phofl Feb 3, 2024

mroeschke Feb 2, 2024

phofl Feb 3, 2024

mroeschke commented Feb 2, 2024

mroeschke Feb 2, 2024

phofl Feb 3, 2024

phofl commented Feb 3, 2024

mroeschke left a comment

bersbersbers commented Feb 5, 2024

DEPR: Remove SettingWithCopyWarning #56614

DEPR: Remove SettingWithCopyWarning #56614

Conversation

phofl commented Dec 24, 2023 • edited by mroeschke Loading

jreback commented Dec 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mroeschke commented Feb 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phofl commented Feb 3, 2024

mroeschke left a comment

Choose a reason for hiding this comment

bersbersbers commented Feb 5, 2024

phofl commented Dec 24, 2023 •

edited by mroeschke

Loading