-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: RecursionError with categorical merge keys #56485
Conversation
@@ -1834,14 +1835,31 @@ def np_can_hold_element(dtype: np.dtype, element: Any) -> Any: | |||
raise LossySetitemError | |||
|
|||
if tipo is not None: | |||
if isinstance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that this is the right place if the issue is only in merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue should show up anywhere that tries to determine the result type of an operation using np_can_hold_element
but calls itself in error handling. In the bug report, the problem was happening in putmask
, but a similar issue happened with loc
before.
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/v2.2.0.rst
file if fixing a bug or adding a new feature.Most of this PR is repeated code from #55201. It might be worth generalizing, but I didn't see a clean way.