Skip to content

CoW: Remove false positive warnings for inplace operators #56242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2023
Merged

CoW: Remove false positive warnings for inplace operators #56242

merged 3 commits into from
Dec 4, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 29, 2023 •
edited by jorisvandenbossche
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

xref #56019

@mroeschke mroeschke added Warnings Warnings that appear or should be added to pandas Copy / view semantics labels Nov 30, 2023
jorisvandenbossche
jorisvandenbossche approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche mentioned this pull request Dec 4, 2023
Closed
14 tasks
@jorisvandenbossche jorisvandenbossche merged commit 6669aee into pandas-dev:main Dec 4, 2023
@jorisvandenbossche jorisvandenbossche added this to the 2.2 milestone Dec 4, 2023
@phofl phofl deleted the inplace_cow_warning branch December 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Copy / view semantics Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @jorisvandenbossche @mroeschke