TST: de-xfail some pyarrow tests #55918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 10, 2023
| def test_dtype_with_converters(all_parsers): | ||
| parser = all_parsers | ||
| data = """a,b | ||
| 1.1,2.2 | ||
| 1.2,2.3""" | ||
|
|
||
| if parser.engine == "pyarrow": | ||
| msg = "The 'converters' option is not supported with the 'pyarrow' engine" | ||
| with pytest.raises(ValueError, match=msg): |
There was a problem hiding this comment.
A NotImplementedError would have been more ideal, but I guess NBD.
There was a problem hiding this comment.
i guess i think of NotImplementedError as suggesting it is something we can do something about as opposed to something that isnt implemented upstream
mroeschke
added
Testing
mroeschke
approved these changes
Nov 11, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that we are giving useful exception messages, also these execute more quickly than xfails.