Skip to content

REGR: fix return class in _constructor_from_mgr for simple subclasses #55764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 9, 2023
Merged

REGR: fix return class in _constructor_from_mgr for simple subclasses #55764

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dc210b6
Revert _constructor check
ivirshup Oct 30, 2023
47bb5de
Revert other constructor checks, allow warning in test_reindex_like_s…
ivirshup Oct 30, 2023
6c5086d
Add tests
ivirshup Oct 31, 2023
0b6acff
Merge branch 'main' into check-class-on-constructor-from-mgr
ivirshup Nov 8, 2023
3bf8c8a
Release note
ivirshup Nov 8, 2023
123934d
Add Series test, accept suggestion
ivirshup Nov 8, 2023
c61c690
Revert specific instance check, use of class method now catches this
ivirshup Nov 8, 2023
bac1e95
Fix type checks in tests
ivirshup Nov 8, 2023
885aadb
Update pandas/core/frame.py
jorisvandenbossche Nov 8, 2023
3cb17f1
Update pandas/core/series.py
jorisvandenbossche Nov 8, 2023
22c33c3
Add test for Series.to_frame
ivirshup Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pandas/core/frame.py 
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
  • Loading branch information
@jorisvandenbossche @ivirshup
jorisvandenbossche and ivirshup authored Nov 8, 2023
commit 885aadb9e413158c77ac891da89e01ed77c2fc5c
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ def _sliced_from_mgr(self, mgr, axes) -> Series:
return Series._from_mgr(mgr, axes)

def _constructor_sliced_from_mgr(self, mgr, axes):
if type(self) is DataFrame:
if self._constructor_sliced is Series:
ser = self._sliced_from_mgr(mgr, axes)
ser._name = None # caller is responsible for setting real name
return ser
Expand Down