Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Support for list of formats in pd.to_datetime() (pandas-dev#55226) #55698

Closed
wants to merge 20 commits into from
Closed

ENH: Support for list of formats in pd.to_datetime() (pandas-dev#55226) #55698

wants to merge 20 commits into from

Conversation

gusthavoMFS
Copy link

@gusthavoMFS gusthavoMFS commented Oct 26, 2023 •
edited
Loading

Trying to convert format list for each data list element.

The idea is to make the format argument more flexible to accept a list, in order to specify the format for each date in a list.

MarcoGorelli
MarcoGorelli reviewed Oct 26, 2023
View reviewed changes
pandas/tests/tools/test_to_datetime.py Outdated
[expected_ds, getattr(Timestamp, attribute)()], dtype="datetime64[ns, UTC]"
)
assert (expected - result).max().total_seconds() < 1


#MUDEI AQUI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for starting this - could you mark this as draft please and ping me when it's ready for review?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the encouragement, I've already put it as a draft

@gusthavoMFS gusthavoMFS marked this pull request as draft October 26, 2023 15:14
@gusthavoMFS gusthavoMFS marked this pull request as ready for review November 21, 2023 13:37
@gusthavoMFS
Copy link
Author

Hello @MarcoGorelli we need a review for this code.
Thanks for attention

MarcoGorelli
MarcoGorelli requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a tonne of irrelevant stuff in this PR, please remove it

@leogiuris
Revert "alterations3"
dc1271a 
This reverts commit be1a212.
@leogiuris
Copy link

Hello @MarcoGorelli , I reverted a commit with many graph images that had nothing to do with the issue. Can you review for us? Thank you for your patience.

@github-actions GitHub Actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 25, 2023
MarcoGorelli
MarcoGorelli requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still several unrelated things

there's a lot of stuff to do, please make sure this is in good shape before asking for a review

pandas/core/tools/datetimes.py
@@ -715,13 +718,14 @@ def to_datetime(
...


#MUDANDO AQUI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. this

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli requested changes

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gusthavoMFS @leogiuris @mroeschke @MarcoGorelli