BUG: indexing raises for ea into numpy series #55633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
the
Indexing
mroeschke
reviewed
Oct 23, 2023
| @@ -1816,7 +1816,8 @@ def np_can_hold_element(dtype: np.dtype, element: Any) -> Any: | |||
| if not isinstance(tipo, np.dtype): | |||
| # i.e. nullable IntegerDtype; we can put this into an ndarray | |||
| # losslessly iff it has no NAs | |||
| if element._hasna: | |||
| arr = element._values if isinstance(element, ABCSeries) else element | |||
There was a problem hiding this comment.
Do we need to also include ABCIndex for df.loc[: ,"a"] = Index[Int64]?
There was a problem hiding this comment.
no that's unpacked earlier
mroeschke
approved these changes
Oct 23, 2023
|
Thanks @phofl |
|
Has this been released? I still encounter error that's similar to 55604 |
|
Not yet. Hopefully in January this should be released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.