Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "BUG: Timestamp origin takes no effect in resample for 'MS' frequency (#53938)" #55077

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Sep 9, 2023

closes #55064

This reverts commit dfc4c39.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

I'm just:

  • reverting the commit
  • fixing some merge conflicts due to:
    • random number generator usage
    • 'T' -> 'min' deprecation
  • adding a docs note noting that origin only takes effect for tick-frequencies

and adding a 2.1.1 whatsnew note

@MarcoGorelli MarcoGorelli added this to the 2.1.1 milestone Sep 9, 2023
@MarcoGorelli MarcoGorelli added Regression Functionality that used to work in a prior pandas version Frequency DateOffsets labels Sep 9, 2023
@MarcoGorelli MarcoGorelli marked this pull request as ready for review September 9, 2023 11:39
@lithomas1 lithomas1 modified the milestones: 2.1.1, 2.1.2 Sep 20, 2023
@@ -20,6 +20,7 @@ Fixed regressions
- Fixed regression in :meth:`.GroupBy.get_group` raising for ``axis=1`` (:issue:`54858`)
- Fixed regression in :meth:`DataFrame.__setitem__` raising ``AssertionError`` when setting a :class:`Series` with a partial :class:`MultiIndex` (:issue:`54875`)
- Fixed regression in :meth:`DataFrame.filter` not respecting the order of elements for ``filter`` (:issue:`54980`)
- Fixed regression in :meth:`DataFrame.resample` which was extrapolating back to ``origin`` when ``origin`` was outside its bounds (:issue:`55064`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be moved to 2.1.2 now

@mroeschke mroeschke merged commit e74138c into pandas-dev:main Oct 9, 2023
35 of 39 checks passed
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 9, 2023
MarcoGorelli added a commit that referenced this pull request Oct 24, 2023
…es no effect in resample for 'MS' frequency (#53938)") (#55459)

* Backport PR #55077: Revert "BUG: Timestamp origin takes no effect in resample for 'MS' frequency (#53938)"

* fixup doctest

* noop

* fixup doctests

---------

Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
Co-authored-by: MarcoGorelli <33491632+MarcoGorelli@users.noreply.github.com>
Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: In 2.1.0 .resample extrapolates indexes to any 'origin' defined with Timestamp
3 participants