Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: bump pyarrow min version for div on duration #55048

Merged
merged 1 commit into from
Sep 8, 2023
Merged

COMPAT: bump pyarrow min version for div on duration #55048

merged 1 commit into from
Sep 8, 2023

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented Sep 7, 2023 •
edited
Loading

@bnavigator bnavigator force-pushed the pyarrow-14-div branch 2 times, most recently from 670a510 to f24ced8 Compare September 7, 2023 14:16
@mroeschke
Copy link
Member

Looks like there are some code check and precommit failures otherwise looks good

@mroeschke mroeschke added the Arrow pyarrow functionality label Sep 7, 2023
@bnavigator
Copy link
Contributor Author

I fixed the code check.

Note that this does not address the fact that there is an extensive branch structure depending on the pyarrow version but there is no test matrix covering it. Hence the formerly unnoticed incompatibility with pyarrow 13.0.0

@mroeschke mroeschke added this to the 2.1.1 milestone Sep 8, 2023
@mroeschke mroeschke merged commit 9aa3f95 into pandas-dev:main Sep 8, 2023
38 checks passed
@mroeschke
Copy link
Member

Thanks @bnavigator

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 8, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 8, 2023
@bnavigator @meeseeksmachine
Backport PR pandas-dev#55048: COMPAT: bump pyarrow min version for di…
613e9aa 
…v on duration
mroeschke pushed a commit that referenced this pull request Sep 8, 2023
@meeseeksmachine @bnavigator
Backport PR #55048 on branch 2.1.x (COMPAT: bump pyarrow min version …
dac2a06 
…for div on duration) (#55073)

Backport PR #55048: COMPAT: bump pyarrow min version for div on duration

Co-authored-by: Ben Greiner <code@bnavigator.de>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@bnavigator @mroeschke
COMPAT: bump pyarrow min version for div on duration (pandas-dev#55048)
4815e03 
COMPAT: bump pyarrow min version test for div on duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

BUG: Pandas 2.1.0 and Arrow 13: "Function 'divide' has no kernel matching input types" for durations
2 participants
@bnavigator @mroeschke