Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: updated docstring for deprecation of axis=1 in groupby #54896

Merged
merged 3 commits into from
Aug 31, 2023
Merged

DOC: updated docstring for deprecation of axis=1 in groupby #54896

merged 3 commits into from
Aug 31, 2023

Conversation

rsm-23
Copy link
Contributor

@rsm-23 rsm-23 commented Aug 31, 2023 •
edited
Loading

@rsm-23
Copy link
Contributor Author

rsm-23 commented Aug 31, 2023

@rhshadrach @mroeschke I added a note on the deprecation. Would be great if you could give some inputs here?

@mroeschke mroeschke added this to the 2.1.1 milestone Aug 31, 2023
@mroeschke mroeschke added the Docs label Aug 31, 2023
rhshadrach
rhshadrach approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke merged commit a720c69 into pandas-dev:main Aug 31, 2023
33 checks passed
@mroeschke
Copy link
Member

Thanks @rsm-23

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 31, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 31, 2023
@rsm-23 @meeseeksmachine
Backport PR pandas-dev#54896: DOC: updated docstring for deprecation …
b7d4772 
…of axis=1 in groupby
@rsm-23 rsm-23 deleted the groupby-docstring-deprecation branch August 31, 2023 20:26
mroeschke pushed a commit that referenced this pull request Aug 31, 2023
@meeseeksmachine @rsm-23
Backport PR #54896 on branch 2.1.x (DOC: updated docstring for deprec…
cbff8f1 
…ation of axis=1 in groupby) (#54912)

Backport PR #54896: DOC: updated docstring for deprecation of axis=1 in groupby

Co-authored-by: Rajat Subhra Mukherjee <raromukherjee@gmail.com>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
@rsm-23 @mroeschke
DOC: updated docstring for deprecation of axis=1 in groupby (pandas-d…
8161505 
…ev#54896)

* added deprecation for axis=1

* suggested changes
@code-narrator code-narrator mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

DEPR: Add note to groupby docstring about deprecation of axis=1
3 participants
@rsm-23 @mroeschke @rhshadrach