Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: deprecated nonkeyword arguments in to_stata #54602

Closed
wants to merge 3 commits into from
Closed

DEPR: deprecated nonkeyword arguments in to_stata #54602

wants to merge 3 commits into from

Conversation

rsm-23
Copy link
Contributor

@rsm-23 rsm-23 commented Aug 17, 2023

@rsm-23
Copy link
Contributor Author

rsm-23 commented Aug 17, 2023

@mroeschke the definition of this method already takes care of not allowing any other parameters except path.

  1. Do we still need to add the decorator for this method?
  2. Even if we add it, there's no way we can write a test for this method.

@rsm-23 rsm-23 marked this pull request as ready for review August 17, 2023 20:55
@mroeschke
Copy link
Member

Yeah this method already enforces nonkeyword arguments except path so I think we can close this

@mroeschke mroeschke closed this Aug 17, 2023
@rsm-23 rsm-23 deleted the nonkeyword-to-stata branch August 17, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsm-23 @mroeschke