-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtensionArray.Round method and tests #54582
Open
andrewgsavage
wants to merge
39
commits into
pandas-dev:main
Choose a base branch
from
andrewgsavage:round
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
1125199
add round abc
andrewgsavage a4ef563
add round test
andrewgsavage 9f6ebc9
round tests
andrewgsavage 2f0f100
lint
andrewgsavage 241ba6c
lint
andrewgsavage 457290d
Merge branch 'main' into round
andrewgsavage e2a4168
tests
andrewgsavage a908700
move methods tests, elementwise rounding
andrewgsavage fbbfe46
lint
andrewgsavage 15915dc
remove test
andrewgsavage 4167122
Merge branch 'main' into round
andrewgsavage e31d06a
add default round method
andrewgsavage bfd36f8
merge main
andrewgsavage bc4d8c6
remove invert
andrewgsavage 362cd73
typo
andrewgsavage aa79869
decimal array works now
andrewgsavage 2b694bf
move round to base calss
andrewgsavage 01d1453
move pytest mark into if statement
andrewgsavage e5d500d
nitpick
andrewgsavage 95d07fa
fix pyarrow round dtypes
andrewgsavage f28d82f
implement sparsearray round
andrewgsavage 2299134
lint
andrewgsavage 15a7cac
lint
andrewgsavage ee37b4d
mypy
andrewgsavage 70ebf5a
ignore my py error
andrewgsavage bda7031
Merge branch 'main' into round
andrewgsavage e01130d
remove blocks ignore mypyr
andrewgsavage 2e73b6a
Merge branch 'round' of https://github.com/andrewgsavage/pandas into …
andrewgsavage 2e9cddf
revert cast
andrewgsavage 76c9ba7
typerror for non numerics
andrewgsavage 044f0a1
isna
andrewgsavage 770edf3
cast pyarrow
andrewgsavage 85f67b6
Merge branch 'main' into round
andrewgsavage f3d4520
Update blocks.py
andrewgsavage 398e64b
Update blocks.py
andrewgsavage b0af597
rounding boolean shouldnt error
andrewgsavage 70b6c89
whatsnew
andrewgsavage 8ef99da
Merge branch 'main' into round
andrewgsavage bebe0ac
Update v3.0.0.rst
andrewgsavage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
mypy
- Loading branch information
commit ee37b4dc95a6b88a27585c8e6f839c5d796f8ea8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.isna
or theself.dtype.na_value
should probably be used to check for na instead ofisna