ENH: Reflect changes from numpy namespace refactor Part 3
#54579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
requested review from
rhshadrach,
MarcoGorelli and
WillAyd
as code owners
mroeschke
reviewed
Aug 16, 2023
| @@ -507,7 +507,7 @@ def test_concat_duplicate_indices_raise(self): | |||
| concat([df1, df2], axis=1) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("dt", np.sctypes["float"]) | |||
| @pytest.mark.parametrize("dt", np.core.sctypes["float"]) | |||
There was a problem hiding this comment.
If it's not good practice to import from np.core, could you just replace this with the float_numpy_dtype fixture?
mroeschke
reviewed
Aug 16, 2023
| @@ -522,7 +522,7 @@ def test_concat_no_unnecessary_upcast(dt, frame_or_series): | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("pdt", [Series, DataFrame]) | |||
| @pytest.mark.parametrize("dt", np.sctypes["int"]) | |||
| @pytest.mark.parametrize("dt", np.core.sctypes["int"]) | |||
There was a problem hiding this comment.
Same but with any_signed_int_numpy_dtype
mroeschke
added
the
Compat
mroeschke
approved these changes
Aug 16, 2023
|
Thanks @mtsokol |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 16, 2023
…pace refactor Part 3
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
…ev#54579) * ENH: Reflect changes from numpy namespace refactor part 3 * ENH: Move to fixtures for dtype access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Due to NumPy's main namespace being changed in numpy/numpy#24376, here I update NumPy's imports/aliases: e.g.
np.NaNandnp.inftywon't be available anymore. Also, a canonical name for NumPy'sfloatandcomplexshould be used, which arenp.float64andnp.complex128.sctypeswill be removed from the top namespace, but its destination is not decided yet - therefore I import it from internalnp.corefor now.