Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Move methods that can be shared with new string dtype #54534

Merged
merged 2 commits into from
Aug 13, 2023
Merged

REF: Move methods that can be shared with new string dtype #54534

merged 2 commits into from
Aug 13, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 13, 2023

cc @jorisvandenbossche

Just a copy-paste

@phofl phofl added the Arrow pyarrow functionality label Aug 13, 2023
@phofl phofl added this to the 2.1 milestone Aug 13, 2023
jorisvandenbossche
jorisvandenbossche approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precursor for #54533? Looks good!

@phofl
Copy link
Member Author

phofl commented Aug 13, 2023

Yep exactly

@phofl phofl merged commit fc30823 into pandas-dev:main Aug 13, 2023
31 of 32 checks passed
@phofl phofl deleted the _arrow_string_mixins branch August 13, 2023 22:38
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 13, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 13, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#54534: REF: Move methods that can be shared wi…
7272da7 
…th new string dtype
phofl added a commit that referenced this pull request Aug 14, 2023
@meeseeksmachine @phofl
Backport PR #54534 on branch 2.1.x (REF: Move methods that can be sha…
64e4527 
…red with new string dtype) (#54539)

Backport PR #54534: REF: Move methods that can be shared with new string dtype

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@phofl @mroeschke
REF: Move methods that can be shared with new string dtype (pandas-de…
bc0002c 
…v#54534)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche