ENH: Implement more efficient merge for arrow strings #54443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
reviewed
Aug 7, 2023
jbrockmendel
reviewed
Aug 7, 2023
| ): | ||
| lk, _ = lk._values_for_factorize() | ||
|
|
||
| # error: Item "ndarray" of "Union[Any, ndarray]" has no attribute | ||
| # "_values_for_factorize" | ||
| rk, _ = rk._values_for_factorize() # type: ignore[union-attr] | ||
| elif isinstance(lk.dtype, ArrowDtype) and is_string_dtype(lk.dtype): |
There was a problem hiding this comment.
no kidding my reaction on reading this was to sigh and then say out loud "gross". let's take this opportunity to implement the appropriate EA method
There was a problem hiding this comment.
:) As discussed, let's do as a follow up. But I agree that this is needed
mroeschke
added
Reshaping
|
A whatsnew note would be good otherwise LGTM |
mroeschke
approved these changes
Aug 8, 2023
|
Thanks @phofl |
| ) | ||
| if how == "right": | ||
| return rlab, llab, count | ||
| return llab, rlab, count |
There was a problem hiding this comment.
should the sort keyword matter somewhere in here?
There was a problem hiding this comment.
Follow-up. This didn't cover sort. Wanted to get the other PR in first
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
* ENH: Implement more efficient merge for arrow strings * Fix typing * Update * ENH: Implement more efficient merge for arrow strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.lets see if this passes ci
Main: 1.4701979160308838
PR: 0.6503970623016357