REF: de-duplicate test_direct_arith_with_ndframe_returns_not_implemented #54410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 4, 2023
pandas/tests/extension/base/ops.py
Outdated
|
|
||
| op_names = tm.arithmetic_dunder_methods + tm.comparison_dunder_methods | ||
| op_names = [x for x in op_names if not x.startswith("__r")] | ||
| for op_name in op_names: |
There was a problem hiding this comment.
I prefer the ergonomics parameterizing this so that the test doesn't stop for a failure for just one op
mroeschke
added
Testing
mroeschke
approved these changes
Aug 4, 2023
|
Thanks @jbrockmendel |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Aug 18, 2023
…ted (pandas-dev#54410) * REF: de-duplicate test_direct_arith_with_ndframe_returns_not_implemented * parametrize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also extends it to test for Index and all the arithmetic/comparison methods instead of just
__add__. Uses a loop inside the test bc im leaning towards trying to slow the expansion of the test suite, but not super-opposed to parametrizing if reviewers have strong opinions.