TST: Remove tm.rands/rands_array #54368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
jbrockmendel
reviewed
Aug 2, 2023
asv_bench/benchmarks/array.py
Outdated
| @@ -80,7 +78,7 @@ def setup(self, multiple_chunks): | |||
| import pyarrow as pa | |||
| except ImportError: | |||
| raise NotImplementedError | |||
| strings = tm.rands_array(3, 10_000) | |||
| strings = np.array(["a"] * 10_000, dtype=object) | |||
There was a problem hiding this comment.
there's no scenario where having random data could make a difference? i could imagine pyarrow having some optimization for constant data
There was a problem hiding this comment.
Not sure if they hash values or anything but that's a good point. I'll make sure the benchmark use unique values
|
Looks like the failures here we unrelated so merging. Happy to follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.