BUG: Fix Series.groupby raising OutOfBoundsDatetime with DatetimeIndex and month name #54306
Conversation
| try: | ||
| return gpr is obj[gpr.name] | ||
| except (KeyError, IndexError, InvalidIndexError): |
There was a problem hiding this comment.
It seems like any error we hit here will want to be ignored; what are thoughts on just doing try: ... except Exception: return False?
There was a problem hiding this comment.
How would you get an arbitrary exception here? A couple years back we made a concerted effort to be more specific in what we caught
There was a problem hiding this comment.
I think there are other issues caused by not being strict enough here e.g. #51818
There was a problem hiding this comment.
I don't think you can; what I'm thinking is that any exception that can possibly be hit here we want to ignore. I'm not certain that's true though.
There was a problem hiding this comment.
I think the listed exceptions here are ones that make sense if gpr.name is not found in obj.columns. Any other exceptions mean Something Has Gone Wrong and we would want a bug report to be filed
|
Thanks @yuanx749 |
Fix the bug as discussed in #48509 @topper-123
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.