Skip to content

CoW: Return read-only array in Index.values #53704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 20, 2023
Merged

CoW: Return read-only array in Index.values #53704

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3cc9846
BUG: IntervalIndex.get_indexer raising for read only array
phofl Jun 16, 2023
6d050d8
Fix windows failure
phofl Jun 16, 2023
4c2dac9
CoW: Return read-only array in Index.values
phofl Jun 16, 2023
2e45177
Fix test
phofl Jun 18, 2023
6e19b8d
Update
phofl Jun 19, 2023
47d38a2
Merge branch 'main' into index_values
phofl Jun 19, 2023
2f1623a
Update pandas/tests/copy_view/test_setitem.py
jorisvandenbossche Jun 20, 2023
7fe0283
Update pandas/tests/indexes/numeric/test_numeric.py
jorisvandenbossche Jun 20, 2023
02632a9
Merge remote-tracking branch 'upstream/main' into index_values
phofl Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pandas/tests/copy_view/test_setitem.py
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche authored Jun 20, 2023
commit 2f1623a9a0b77082f7bd335870f89d51360d5d89
6 changes: 0 additions & 6 deletions pandas/tests/copy_view/test_setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ def test_set_column_with_index(using_copy_on_write):
df["d"] = idx

assert not np.shares_memory(get_array(df, "d"), arr)
if using_copy_on_write:
with pytest.raises(ValueError, match="assignment"):
arr[0] = 0
else:
arr[0] = 0
tm.assert_series_equal(df["d"], Series([1, 2, 3], name="d"))


def test_set_columns_with_dataframe(using_copy_on_write):
Expand Down