Merge branch 'main' into depr-period-b

doc/source/whatsnew/v2.1.0.rst

@@ -347,6 +347,7 @@ Deprecations
 - Deprecated unused "closed" keyword in the :class:`TimedeltaIndex` constructor (:issue:`52628`)
 - Deprecated logical operation between two non boolean :class:`Series` with different indexes always coercing the result to bool dtype. In a future version, this will maintain the return type of the inputs. (:issue:`52500`, :issue:`52538`)
 - Deprecated :class:`Period` and :class:`PeriodDtype` with ``BDay`` freq, use a :class:`DatetimeIndex` with ``BDay`` freq instead (:issue:`53446`)
+- Deprecated :func:`value_counts`, use ``pd.Series(obj).value_counts()`` instead (:issue:`47862`)
 - Deprecated :meth:`Series.first` and :meth:`DataFrame.first` (please create a mask and filter using ``.loc`` instead) (:issue:`45908`)
 - Deprecated :meth:`Series.interpolate` and :meth:`DataFrame.interpolate` for object-dtype (:issue:`53631`)
 - Deprecated :meth:`Series.last` and :meth:`DataFrame.last` (please create a mask and filter using ``.loc`` instead) (:issue:`53692`)

pandas/tests/indexes/period/test_period.py

@@ -134,46 +134,9 @@ def test_period_index_length(self):
         with pytest.raises(ValueError, match=msg):
             PeriodIndex(vals)
 
-    # @pytest.mark.filterwarnings("ignore:Period with BDay freq:FutureWarning")
-    def test_fields(self):
-        # year, month, day, hour, minute
-        # second, weekofyear, week, dayofweek, weekday, dayofyear, quarter
-        # qyear
-        pi = period_range(freq="A", start="1/1/2001", end="12/1/2005")
-        self._check_all_fields(pi)
-
-        pi = period_range(freq="Q", start="1/1/2001", end="12/1/2002")
-        self._check_all_fields(pi)
-
-        pi = period_range(freq="M", start="1/1/2001", end="1/1/2002")
-        self._check_all_fields(pi)
-
-        pi = period_range(freq="D", start="12/1/2001", end="6/1/2001")
-        self._check_all_fields(pi)
-
-        msg2 = "Period with BDay freq is deprecated"
-
-        with tm.assert_produces_warning(FutureWarning, match=msg2):
-            pi = period_range(freq="B", start="12/1/2001", end="6/1/2001")
-        self._check_all_fields(pi)
-
-        pi = period_range(freq="H", start="12/31/2001", end="1/1/2002 23:00")
-        self._check_all_fields(pi)
-
-        pi = period_range(freq="Min", start="12/31/2001", end="1/1/2002 00:20")
-        self._check_all_fields(pi)
-
-        pi = period_range(
-            freq="S", start="12/31/2001 00:00:00", end="12/31/2001 00:05:00"
-        )
-        self._check_all_fields(pi)
-
-        end_intv = Period("2006-12-31", "W")
-        i1 = period_range(end=end_intv, periods=10)
-        self._check_all_fields(i1)
-
-    def _check_all_fields(self, periodindex):
-        fields = [
+    @pytest.mark.parametrize(
+        "field",
+        [
             "year",
             "month",
             "day",
@@ -198,7 +161,6 @@ def _check_all_fields(self, periodindex):
             period_range(freq="Q", start="1/1/2001", end="12/1/2002"),
             period_range(freq="M", start="1/1/2001", end="1/1/2002"),
             period_range(freq="D", start="12/1/2001", end="6/1/2001"),
-            period_range(freq="B", start="12/1/2001", end="6/1/2001"),
             period_range(freq="H", start="12/31/2001", end="1/1/2002 23:00"),
             period_range(freq="Min", start="12/31/2001", end="1/1/2002 00:20"),
             period_range(

pandas/tests/plotting/frame/test_frame.py

@@ -357,9 +357,10 @@ def test_xcompat_plot_period(self):
         ax = df.plot()
         lines = ax.get_lines()
         assert not isinstance(lines[0].get_xdata(), PeriodIndex)
+        msg = r"PeriodDtype\[B\] is deprecated "
         with tm.assert_produces_warning(FutureWarning, match=msg):
             assert isinstance(PeriodIndex(lines[0].get_xdata()), PeriodIndex)
-        self._check_ticks_props(ax, xrot=0)
+        _check_ticks_props(ax, xrot=0)
 
     def test_period_compat(self):
         # GH 9012

pandas/tests/plotting/test_datetimelike.py

@@ -370,13 +370,21 @@ def test_dataframe(self):
     @pytest.mark.filterwarnings(
         "ignore:Period with BDay freq is deprecated:FutureWarning"
     )
-    def test_axis_limits(self):
-        def _test(ax):
-            xlim = ax.get_xlim()
-            ax.set_xlim(xlim[0] - 5, xlim[1] + 10)
-            result = ax.get_xlim()
-            assert result[0] == xlim[0] - 5
-            assert result[1] == xlim[1] + 10
+    @pytest.mark.parametrize(
+        "obj",
+        [
+            tm.makeTimeSeries(),
+            DataFrame({"a": tm.makeTimeSeries(), "b": tm.makeTimeSeries() + 1}),
+        ],
+    )
+    def test_axis_limits(self, obj):
+        _, ax = mpl.pyplot.subplots()
+        obj.plot(ax=ax)
+        xlim = ax.get_xlim()
+        ax.set_xlim(xlim[0] - 5, xlim[1] + 10)
+        result = ax.get_xlim()
+        assert result[0] == xlim[0] - 5
+        assert result[1] == xlim[1] + 10
 
         # string
         expected = (Period("1/1/2000", ax.freq), Period("4/1/2000", ax.freq))
@@ -814,10 +822,10 @@ def test_mixed_freq_irreg_period(self):
         msg = r"PeriodDtype\[B\] is deprecated"
         with tm.assert_produces_warning(FutureWarning, match=msg):
             rng = period_range("1/3/2000", periods=30, freq="B")
-            ps = Series(np.random.randn(len(rng)), rng)
-            _, ax = self.plt.subplots()
-            irreg.plot(ax=ax)
-            ps.plot(ax=ax)
+        ps = Series(np.random.randn(len(rng)), rng)
+        _, ax = mpl.pyplot.subplots()
+        irreg.plot(ax=ax)
+        ps.plot(ax=ax)
 
     def test_mixed_freq_shared_ax(self):
         # GH13341, using sharex=True