BUG: read_sql reading duplicate tz aware columns #53311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
IO SQL
phofl
reviewed
May 20, 2023
pandas/tests/io/test_sql.py
Outdated
| @pytest.mark.parametrize("conn", postgresql_connectable) | ||
| def test_self_join_date_columns(conn, request): | ||
| # GH 44421 | ||
| conn = request.getfixturevalue(conn) |
There was a problem hiding this comment.
Can we add this to the Postgres class? The classes are skipped when no db is detected
There was a problem hiding this comment.
Sure moved (though I think eventually we should move these classes to the functional fixture instead of the class based ones)
|
Going to merge, but happy to follow up if needed |
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
Jun 5, 2023
* BUG: read_sql reading duplicate tz aware columns * Use isetitem * Move to postgres class
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* BUG: read_sql reading duplicate tz aware columns * Use isetitem * Move to postgres class
|
@mroeschke thanks! Any chance this bugfix could be backported to pandas 2.0.x too? |
|
Typically the backport branch is only maintained until the following minor release or just after. Now that the latest version is 2.2.0, it is extremely unlikely that any further patch releases will happen in the 2.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.