Skip to content

CoW: Avoid copying Index in Series constructor #52008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorisvandenbossche merged 5 commits into from
Mar 17, 2023
Merged

CoW: Avoid copying Index in Series constructor #52008

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58e4b29
CoW: Avoid copying Index in Series constructor
phofl Mar 15, 2023
865b491
Fix mypy
phofl Mar 16, 2023
f8d45c9
Fix tests
phofl Mar 16, 2023
7f6025b
Fix tests
phofl Mar 16, 2023
1e0387d
Fix
phofl Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@phofl
phofl committed Mar 16, 2023
commit f8d45c90163f4fa270ae181d9f7b688fd1aa7d0b
3 changes: 3 additions & 0 deletions pandas/tests/copy_view/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from pandas import (
Categorical,
Index,
Series,
)
Expand All @@ -24,4 +25,6 @@ def get_array(obj, col=None):
arr = obj._get_column_array(icol)
if isinstance(arr, BaseMaskedArray):
return arr._data
elif isinstance(arr, Categorical):
return arr
return getattr(arr, "_ndarray", arr)