DOC: Improvements to groupby.rst #51626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Docs
Groupby
Nuisance Columns
phofl
reviewed
Feb 25, 2023
doc/source/user_guide/groupby.rst
Outdated
|
|
||
| ``apply`` has to try to infer from the result whether it should act as a reducer, | ||
| transformer, *or* filter, depending on exactly what is passed to it. Thus the | ||
| grouped column(s) may be included in the output as well as set the indices. While |
There was a problem hiding this comment.
may be included in the output as well as set as the indices
This sounds better to me, but best to double check, otherwise lgtm
There was a problem hiding this comment.
Indeed - thanks. I also changed it from "as well as" to "or" since we don't do both.
There was a problem hiding this comment.
Actually - looking at this again I think we want to say "may be included in the output or not"
phofl
approved these changes
Feb 26, 2023
|
thx @rhshadrach |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Doing a general cleanup of the groupby user guide. The main new thing being introduce here is language to steer users way from groupby.apply.