Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: setting non-string value into StringArray raises ValueError instead of TypeError #51191

Merged
merged 2 commits into from
Feb 6, 2023
Merged

BUG: setting non-string value into StringArray raises ValueError instead of TypeError #51191

merged 2 commits into from
Feb 6, 2023

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Feb 6, 2023

@mroeschke mroeschke requested a review from phofl February 6, 2023 18:43
@mroeschke mroeschke added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 6, 2023
@phofl phofl added this to the 2.0 milestone Feb 6, 2023
@phofl phofl merged commit ad03e49 into pandas-dev:main Feb 6, 2023
@phofl
Copy link
Member

phofl commented Feb 6, 2023

thx @yuanx749

@phofl phofl added the Error Reporting Incorrect or improved errors from pandas label Feb 6, 2023
@yuanx749 yuanx749 deleted the string-array-typeerror branch February 7, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: Differences in setting value error between string dtype and others
3 participants
@yuanx749 @phofl @mroeschke