ENH: Optimize replace to avoid copying when not necessary #50918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix any of the existing cases in |
|
No, not yet |
lithomas1
reviewed
Jan 31, 2023
3 tasks
# Conflicts: # pandas/tests/copy_view/test_replace.py
# Conflicts: # pandas/tests/copy_view/test_methods.py # pandas/tests/copy_view/test_replace.py
lithomas1
reviewed
Feb 15, 2023
| if using_cow: | ||
| return [self.copy(deep=False)] | ||
| else: | ||
| return [self] if inplace else [self.copy()] | ||
|
|
||
| if mask is None: | ||
| mask = missing.mask_missing(values, to_replace) | ||
| if not mask.any(): |
There was a problem hiding this comment.
If we pass an axis(I thinkaxis=0 should work, need to be careful of 1-D values/mask though), than we should have enough info to split the block.
There was a problem hiding this comment.
Yep agree, but right now this is not that high on my list of priorities. With the ref tracking how it is right now, this only defers the copy a little bit
|
thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 26, 2023
…when not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.