Skip to content

CI: Make some builds contents read only #50566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

mroeschke
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Build Library building on various platforms CI Continuous Integration labels Jan 4, 2023
@mroeschke mroeschke requested a review from lithomas1 January 4, 2023 21:24
@lithomas1 lithomas1 added this to the 1.5.3 milestone Jan 5, 2023
@mroeschke mroeschke merged commit e16569a into pandas-dev:main Jan 5, 2023
@mroeschke mroeschke deleted the ci/read_contents branch January 5, 2023 02:44
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 5, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e16569a0041759e5bbb142636d3cc158dadd761f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50566: CI: Make some builds contents read only'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50566-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50566 on branch 1.5.x (CI: Make some builds contents read only)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member Author

@meeseeksmachine backport 1.5.x

@mroeschke
Copy link
Member Author

@meeseeksdev backport 1.5.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 5, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 1.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e16569a0041759e5bbb142636d3cc158dadd761f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #50566: CI: Make some builds contents read only'
  1. Push to a named branch:
git push YOURFORK 1.5.x:auto-backport-of-pr-50566-on-1.5.x
  1. Create a PR against branch 1.5.x, I would have named this PR:

"Backport PR #50566 on branch 1.5.x (CI: Make some builds contents read only)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member Author

Looks like wheels.yml does not exist on 1.5.x so backporting would require backporting that file. IMO this change pretty minor so probably not worth backporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants