Skip to content

BUG: Fix more interchange Column.size method #50565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2023
Merged

BUG: Fix more interchange Column.size method #50565

merged 5 commits into from
Jan 6, 2023

Conversation

@mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 4, 2023 •
edited
Loading

Like #48426 part of the updated interchange protocol introduced in 1.5

@mroeschke mroeschke added the Interchange Dataframe Interchange Protocol label Jan 4, 2023
@mroeschke mroeschke added this to the 1.5.3 milestone Jan 4, 2023
@phofl phofl merged commit 2ef976c into pandas-dev:main Jan 6, 2023
@phofl
Copy link
Member

phofl commented Jan 6, 2023

thx @mroeschke

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 6, 2023
@mroeschke @meeseeksmachine
Backport PR pandas-dev#50565: BUG: Fix more interchange Column.size m…
2ccf064 
…ethod
@mroeschke mroeschke deleted the bug/interchange/size branch January 6, 2023 23:26
lithomas1 pushed a commit that referenced this pull request Jan 7, 2023
@meeseeksmachine @mroeschke
Backport PR #50565 on branch 1.5.x (BUG: Fix more interchange Column.…
43073cc 
…size method) (#50610)

Backport PR #50565: BUG: Fix more interchange Column.size method

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jan 7, 2023

FWIW, I think it would be useful to add a test that actually covers this

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 10, 2023
Closed
@mroeschke mroeschke mentioned this pull request Jan 12, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phofl phofl phofl approved these changes

Assignees

No one assigned

Labels

Interchange Dataframe Interchange Protocol

Projects

None yet

Milestone

1.5.3

Development

Successfully merging this pull request may close these issues.

BUG: Interchange Column.size() is still called as a property in some places

3 participants

@mroeschke @phofl @jorisvandenbossche