Skip to content

ENH: Add lazy copy to concat and round #50501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jan 17, 2023
Merged

ENH: Add lazy copy to concat and round #50501

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
94c982e
Start with implmenting concat for cow
phofl Dec 24, 2022
7fbba4a
Merge remote-tracking branch 'upstream/main' into cow_concat_new
phofl Dec 30, 2022
0db1c39
Fix concat logic
phofl Dec 30, 2022
fc564f8
Add series test
phofl Dec 30, 2022
a7165c2
Clean up
phofl Dec 30, 2022
20a62bb
Skip test
phofl Dec 30, 2022
bca2123
Fix test
phofl Dec 30, 2022
3c4abd2
Add check
phofl Jan 7, 2023
7734979
Merge remote-tracking branch 'upstream/main' into cow_concat_new
phofl Jan 7, 2023
8bc3272
Push logic down
phofl Jan 7, 2023
79cedd4
Fix test
phofl Jan 7, 2023
6c8a704
Fix typing
phofl Jan 7, 2023
de678ab
Merge branch 'main' into cow_concat_new
phofl Jan 12, 2023
dddc9f0
Fix annotation
phofl Jan 13, 2023
d18416d
Fix chained concat
phofl Jan 13, 2023
5ccf23e
Pass to bm
phofl Jan 13, 2023
7648b23
Fix series case
phofl Jan 13, 2023
99da573
Update pandas/core/internals/concat.py
phofl Jan 13, 2023
a6afa8b
Fix concat
phofl Jan 13, 2023
3d0772c
Merge remote-tracking branch 'upstream/main' into cow_concat_new
phofl Jan 13, 2023
8b49210
Fix chained series case
phofl Jan 13, 2023
48a4f7e
Merge remote-tracking branch 'upstream/main' into cow_concat_new
phofl Jan 13, 2023
690f072
Merge remote-tracking branch 'upstream/main' into cow_concat_new
phofl Jan 15, 2023
8ba35fe
Fix mypy
phofl Jan 15, 2023
2047d5c
Fix bug
phofl Jan 15, 2023
e959c53
Add test and flag
phofl Jan 16, 2023
891e07c
Fix hdf test
phofl Jan 16, 2023
04adc17
Fix mypy
phofl Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix annotation
  • Loading branch information
@phofl
phofl committed Jan 13, 2023
commit dddc9f0f7ef17a73b46ba98f51e27d1345ffeb8b
6 changes: 2 additions & 4 deletions pandas/core/internals/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import itertools
from typing import (
TYPE_CHECKING,
List,
Optional,
Sequence,
cast,
)
Expand Down Expand Up @@ -273,7 +271,7 @@ def _concat_managers_axis0(

offset = 0
blocks = []
refs = []
refs: list[weakref.ref | None] = []
parent = None
for i, mgr in enumerate(mgrs):
# If we already reindexed, then we definitely don't need another copy
Expand All @@ -299,7 +297,7 @@ def _concat_managers_axis0(

result = BlockManager(tuple(blocks), axes)
result.parent = parent
result.refs = cast(Optional[List[Optional[weakref.ref]]], refs) if refs else None
result.refs = refs if refs else None
return result


Expand Down