Skip to content

API / CoW: constructing DataFrame from DataFrame creates lazy copy #50499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phofl wants to merge 10 commits into from
Closed

API / CoW: constructing DataFrame from DataFrame creates lazy copy #50499

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1ba93e4
BUG: DataFrame constructor not tracking reference if called with df o…
phofl Dec 30, 2022
24912bd
Add gh ref
phofl Dec 30, 2022
11a1db8
Fix tests
phofl Dec 30, 2022
bd304fc
Restrict to dataframes, not managers
phofl Dec 30, 2022
c51a204
Fix for now
phofl Dec 30, 2022
2984d21
Merge remote-tracking branch 'upstream/main' into cow_mgr_constructor
phofl Jan 7, 2023
f221e0c
Merge remote-tracking branch 'upstream/main' into cow_mgr_constructor
phofl Jan 7, 2023
a434340
Fix test
phofl Jan 7, 2023
57919a5
Merge branch 'main' into cow_mgr_constructor
phofl Jan 7, 2023
094c0e9
Merge branch 'main' into cow_mgr_constructor
phofl Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@phofl
phofl committed Jan 7, 2023
commit a4343408aa27a53120ea111fc2d53f9a800de92d
5 changes: 3 additions & 2 deletions pandas/tests/frame/methods/test_align.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
date_range,
)
import pandas._testing as tm
from pandas.core.internals.managers import using_copy_on_write


class TestDataFrameAlign:
Expand Down Expand Up @@ -40,12 +41,12 @@ def test_frame_align_aware(self):
assert new1.index.tz is timezone.utc
assert new2.index.tz is timezone.utc

def test_align_float(self, float_frame, using_copy_on_write, using_array_manager):
def test_align_float(self, float_frame):
af, bf = float_frame.align(float_frame)
assert af._mgr is not float_frame._mgr

af, bf = float_frame.align(float_frame, copy=False)
if using_copy_on_write or using_array_manager:
if using_copy_on_write():
assert af._mgr is not float_frame._mgr
else:
assert af._mgr is float_frame._mgr
Expand Down