Skip to content

DOC: skip a doctest that writes to disk #50454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

DOC: skip a doctest that writes to disk #50454

merged 1 commit into from
Dec 28, 2022

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Dec 28, 2022

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Running ./scripts/validate_docstrings.py was returning the following error

Exception: The following files were leftover from the doctest: {'formatted_file.xlsx'}. Please use # doctest: +SKIP

This was due to the doctest writing to disk. This PR fixes this issue.

@rhshadrach rhshadrach added Docs Styler conditional formatting using DataFrame.style labels Dec 28, 2022
@rhshadrach rhshadrach requested a review from attack68 December 28, 2022 05:10
rhshadrach
rhshadrach approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 2.0 milestone Dec 28, 2022
@phofl phofl merged commit 428c2a6 into pandas-dev:main Dec 28, 2022
@phofl
Copy link
Member

phofl commented Dec 28, 2022

thx @Moisan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@phofl phofl phofl approved these changes

@attack68 attack68 Awaiting requested review from attack68 attack68 is a code owner

Assignees
No one assigned
Labels
Docs Styler conditional formatting using DataFrame.style
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @phofl @rhshadrach