Add nanoseconds to timestamps stub file #50374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also found the documentation to be lacking. I had to try it out to determine if `nanoseconds` would be giving me all nanoseconds until the next full second or just until the next full microsecond (the latter is the case).
phofl
reviewed
Dec 21, 2022
doc/source/whatsnew/v1.5.3.rst
Outdated
| @@ -30,6 +30,7 @@ Bug fixes | |||
| - Bug in :meth:`.Styler.to_excel` leading to error when unrecognized ``border-style`` (e.g. ``"hair"``) provided to Excel writers (:issue:`48649`) | |||
| - Bug when chaining several :meth:`.Styler.concat` calls, only the last styler was concatenated (:issue:`49207`) | |||
| - Fixed bug when instantiating a :class:`DataFrame` subclass inheriting from ``typing.Generic`` that triggered a ``UserWarning`` on python 3.11 (:issue:`49649`) | |||
| - Typing: add :attr:`.Timestamp.nanosecond` to :class:`Timestamp` | |||
There was a problem hiding this comment.
This is only internal, we don't need a whatsnew for this
There was a problem hiding this comment.
On second thought 🤔 is it internal though? If users run a typechecker and have an #type: ignore comment everywhere they use the nanosecond property, they won't get informed that they can possibly remove those.
This reverts commit 00ae238.
mroeschke
approved these changes
Dec 27, 2022
|
Thanks @robsdedude |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also found the documentation to be lacking. I had to try it out to determine if
nanosecondswould be giving me all nanoseconds until the next full second or just until the next full microsecond (the latter is the case).Added an entry in the latestAs suggested by @phofl not neededdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.