Skip to content

PERF: first try inplace setitem for .at indexer #49772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2022
Merged

PERF: first try inplace setitem for .at indexer #49772

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f19550
add inplace
jorisvandenbossche Nov 18, 2022
3a62667
add back LossySetitemError
jorisvandenbossche Nov 18, 2022
f1341a8
add whatsnew
jorisvandenbossche Nov 18, 2022
0a13dcb
Merge remote-tracking branch 'upstream/main' into perf-at-loop
jorisvandenbossche Nov 28, 2022
000278b
update comment
jorisvandenbossche Nov 28, 2022
300c281
add benchmark
jorisvandenbossche Nov 28, 2022
c0f2a10
Merge remote-tracking branch 'upstream/main' into perf-at-loop
jorisvandenbossche Nov 28, 2022
86f8a5c
Merge remote-tracking branch 'upstream/main' into perf-at-loop
jorisvandenbossche Dec 8, 2022
87436d9
update whatsnew
jorisvandenbossche Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into perf-at-loop
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Nov 28, 2022
commit 0a13dcbcb126fbf198a6f0d4c4b62eaa56a1921e
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.5.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Fixed regressions
from being passed using the ``colormap`` argument if Matplotlib 3.6+ is used (:issue:`49374`)
- Fixed regression in :func:`date_range` returning an invalid set of periods for ``CustomBusinessDay`` frequency and ``start`` date with timezone (:issue:`49441`)
- Fixed performance regression in groupby operations (:issue:`49676`)
- Fixed performance regression in the :meth:`~DataFrame.at` indexer (:issue:`49771`)
- Fixed regression in :class:`Timedelta` constructor returning object of wrong type when subclassing ``Timedelta`` (:issue:`49579`)

.. ---------------------------------------------------------------------------
.. _whatsnew_152.bug_fixes:
Expand Down
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.5.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Fixed regressions
- Fixed regression in :meth:`DataFrameGroupBy.transform` when used with ``as_index=False`` (:issue:`49834`)
- Enforced reversion of ``color`` as an alias for ``c`` and ``size`` as an alias for ``s`` in function :meth:`DataFrame.plot.scatter` (:issue:`49732`)
- Fixed regression in :meth:`SeriesGroupBy.apply` setting a ``name`` attribute on the result if the result was a :class:`DataFrame` (:issue:`49907`)
- Fixed performance regression in the :meth:`~DataFrame.at` indexer (:issue:`49771`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clarify it is setitem and not getitem

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

-

.. ---------------------------------------------------------------------------
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.