Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the conversion from dtype to subclass just a little faster #49393

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Make the conversion from dtype to subclass just a little faster #49393

merged 1 commit into from
Nov 2, 2022

Conversation

hmaarrfk
Copy link
Contributor

Calling is_float_dtype is a really "safe" way to take an array or a dtype and know if it is a subclass.

But I don't think you need to do that. Checking the kind should be enough. I get about 5-10% faster on the benchmarks shown. Mostly reducing 12us to 11.5 us. I think it is real.

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@hmaarrfk hmaarrfk mentioned this pull request Oct 29, 2022
Open
@hmaarrfk
Copy link
Contributor Author

I think maybe my knowledge of "isinstance" is really outdated. I can't find a meaningful difference running the benchmarks on my computers.

oh well.

@hmaarrfk
Copy link
Contributor Author

feel free to close or merge, sorry for the noise.

jbrockmendel
jbrockmendel reviewed Oct 30, 2022
View reviewed changes
pandas/core/indexes/base.py
from pandas.core.api import Int64Index

return Int64Index

elif dtype == _dtype_obj:
elif dtype.kind == "O":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure that object dtype is the only one with dtype.kind == "O"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
https://numpy.org/doc/stable/reference/arrays.dtypes.html

mroeschke
mroeschke reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm -0.25 on this change and would slightly prefer the strict behavior over the minimal performance gain.

Based on experience working on ArrowDtype, kind checks may have unintended consequences from ExtensionDtype

@jbrockmendel
Copy link
Member

ExtensionDtype case is handled separately above. its also a bit of a moot point since Float64Index, Int64Index, and UInt64Index are going away soon.

@mroeschke
Copy link
Member

Ah I missed that portion of the function. Okay I think I would be okay with this then

@mroeschke mroeschke added Performance Memory or execution speed performance Index Related to the Index class or subclasses labels Nov 1, 2022
@jbrockmendel jbrockmendel merged commit a793802 into pandas-dev:main Nov 2, 2022
@jbrockmendel
Copy link
Member

thanks @hmaarrfk

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Nov 2, 2022

👍🏾

lithomas1 added a commit to lithomas1/pandas that referenced this pull request Nov 9, 2022
@lithomas1
Squashed commit of the following:
9b64577 
commit 335ccf80e590baf339917e3a111125a20c34384b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 9 10:36:17 2022 -0500

    restore doc build and fix wrong python on macos

commit c4c3f9b29bf64611fd452f340c81790f02e7c5c9
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 9 10:13:00 2022 -0500

    Try for green sans 32-bit

commit 4d0a15bca62afe626b90eaa12d3cbdf18a37a9bf
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 9 08:44:28 2022 -0500

    Going for green

commit ecb6f6e011b926b10dfb1f424cd184d8e1660609
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 9 06:40:37 2022 -0500

    Bring back everything but compilers

commit aa57379fa93cff87c9cf5e61b7bc2547f59420c9
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 21:46:38 2022 -0500

    try to fix strdup not found by lowering compiler strictness

commit dec531721560664230d4d0f58b5f58d6f81d5409
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 21:12:04 2022 -0500

    use catchsegv properly

commit a948860a98266b86772ac01295fbae92e0e07520
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 20:54:13 2022 -0500

    catchsegv and debug build

commit 71bcd582482a1114c7f35952e16e5a6d7687759b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 20:21:45 2022 -0500

    try to catch the segfault

commit a16e98989a4a86a460825853256730205915a7d2
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 18:21:46 2022 -0500

    Silence warnings and debug more

commit 7a2bb0caaadbe57142dfff6a35a5a539b757a311
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 17:50:41 2022 -0500

    Debug more

commit 26435dd35267334d523a677756dfc528fe91ea00
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 17:21:54 2022 -0500

    bring back more packages

commit 05d2f533d3b550303c04f0ae175bf3db14fcda78
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 17:09:35 2022 -0500

    add matplotlib back

commit a4c33898de8d0803a4aa97999d68f3ec7c52408d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Nov 8 07:28:47 2022 -0500

    add back web deps

commit dd0f03c8ccc7296abcf3f62712bafb9394ad45fa
Merge: 6cbdfb8be7 dd65aaf559
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Nov 7 21:25:02 2022 -0500

    Merge branch 'meson-poc' of github.com:lithomas1/pandas into meson-poc

commit 6cbdfb8be7bc56681bb0eb3d100838afc1e0b345
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Nov 7 21:24:25 2022 -0500

    try to get minimal doc build that doesn't segfault

commit dd65aaf559e0cfd9c71261e3420207a53b310a5b
Merge: b7e6624a2d 1d8922e20b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sun Nov 6 17:03:31 2022 -0500

    Merge branch 'pandas-dev:main' into meson-poc

commit 1d8922e20b3384d56551646dfbae2f4c4e458da0
Author: Luke Manley <lukemanley@gmail.com>
Date:   Sun Nov 6 11:53:44 2022 -0500

    CLN: MultiIndex._values remove special casing for Timestamp.freq (#49559)

commit b7e6624a2d905aabf24b1b9493996889ba41da57
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sun Nov 6 10:56:51 2022 -0500

    try not installing conda-forge c/cxx-compiler

commit 85c2cb360741c87abbe4a2c39cb2999c929ab031
Author: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Date:   Sun Nov 6 15:55:00 2022 +0100

    CLN: Remove unused code in Factorizer classes (#49547)

commit a7da45d8335507f9a561a5d47e99c4b0de24b7e9
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sun Nov 6 07:49:10 2022 -0500

    CI: Fix wheel builder uploading (#49544)

commit 0b931173c842a3476646b627422cf943d15288f6
Author: Luke Manley <lukemanley@gmail.com>
Date:   Sun Nov 6 02:47:34 2022 -0500

    TYP: Series.groupby (#49542)

    level arg to be typed IndexLabel

commit f332143172c6345f28ea2a39f84a9bffef840ca6
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Sat Nov 5 13:52:28 2022 -0700

     ENH: Implement io.nullable_backend config for read_csv(engine="pyarrow") (#49366)

commit fa41c52c3dec0597a39910ade667084a16169b28
Author: Aleksa Radojicic <104728490+radojicic23@users.noreply.github.com>
Date:   Sat Nov 5 18:02:28 2022 +0100

    DOC: replaced Gitter link with Slack link in README. (#49546)

    DOC: replaced gitter link with slack link in README

commit 16baf871eebeaa604891893a395456c80293a092
Author: Luke Manley <lukemanley@gmail.com>
Date:   Sat Nov 5 12:14:39 2022 -0400

    CLN: CategoricalIndex.reindex (#49513)

    * remove CategoricalIndex.reindex in favor of base class

    * retain checks

commit 92775821c198727b0c2b61d6f1a965158f378102
Merge: a3a4eb548a 6f97335727
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Nov 5 07:11:34 2022 -0400

    Merge branch 'meson-poc' of github.com:lithomas1/pandas into meson-poc

commit a3a4eb548a0dca4f71f39d695602e92dd7f9e557
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Nov 5 07:10:37 2022 -0400

    update and take another stab at fixing the docs

commit 2a2daf787c5bf4015729f6660d189389d3d7dc47
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Sat Nov 5 10:49:26 2022 +0000

    CI: only run pylint in CI (#49538)

    * Modify precommit config yaml and change name of typing step to Typing + pylint.

    * undo language: system

    Co-authored-by: Sudhansu <13695177+the-lazy-learner@users.noreply.github.com>
    Co-authored-by: MarcoGorelli <>

commit 16645fedb7d9895395488d4d90dc06bd47510057
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Sat Nov 5 05:31:10 2022 +0000

    CI fixup pylint ci failure (#49537)

    fixup pylint ci failure

    Co-authored-by: MarcoGorelli <>

commit 081c06bfb0fc97a38ac1458d5b5154d8a9030e51
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 16:40:50 2022 -0700

    DEPR: enforce indexing deprecations (#49511)

    * DEPR: enforce deprecation of string indexing on DataFrame rows

    * DEPR: set, dict indexers, DataFrame indexer in iloc

    * DEPR: disallow passing list to xs

    * update doc

    * update docstring, typo fixup

commit 6dc92ad0087984555f4204d2fe00384f5462837f
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Fri Nov 4 22:26:45 2022 +0100

    STYLE pylint: 48855-duplicate-value (#49533)

commit 7e9ca6e8af2f97e62a69242d40159994ce1d6178
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Fri Nov 4 20:52:02 2022 +0000

    CLN use default_index more (#49478)

    * use default_index more

    * dont change for columns

    * :memo: add whatsnew note

    Co-authored-by: MarcoGorelli <>

commit 4d7d9217ba190c189f66c66149464dd493cd031b
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 13:30:43 2022 -0700

    DEPR: lookup, append (#49481)

    * DEPR: lookup, append

    * update docs, fix tests

    * rm test_append files

    * update tests

    * fix doc

    * remove asvs

commit d13c9e034ce8a1d738766c4b1cec80c76f5523be
Author: Carlotta Fabian <73344238+fabinca@users.noreply.github.com>
Date:   Fri Nov 4 20:45:23 2022 +0100

    STYLE: fix pylint: no-else-raise (#49520)

    * fix pylint: no-else-raise

    * fix possible imbalanced tuple unpacking warning

    Co-authored-by: carlotta <c.fabian@turbit.de>

commit 62c0fb880014c098df194777e7aee22613c5f6e0
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 11:42:16 2022 -0700

    DEPR: enforce non-positional, keyword deprecations (#49507)

commit cd38fa369d12e8390189f14fe7fcf6533998f5ce
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 11:14:02 2022 -0700

    API: to_timedelta([bad_type]) TypeError instead of ValueError (#49525)

    * API: to_timedelta([bad_type]) TypeError instead of ValueError

    * GH ref

commit 01b432c3537dd2fc910e682cd7c03370a67710c4
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 11:09:41 2022 -0700

    DEPR: Remove deprecated Timestamp.freq (#49365)

    * DEPR: Timestamp.freq

    * __new__, doc

    * update pickle tests

    * update docs

    * update asvs

    * more whatsnew

commit 5a11eb5efc2390a3bcc80fb646496095c1da433d
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 10:20:38 2022 -0700

    DEPR Series[td64].fillna(incompatible) (#49479)

commit 586cc351b89cd299ecbf8f3ff0ab6dab1b799db0
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Nov 4 09:56:54 2022 -0700

    CLN: assorted follow-ups (#49489)

commit 28115430214ea6d520ab7b2d5243e86f3503c712
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Fri Nov 4 09:54:53 2022 -0700

    DEPR: Enforce melt(value_name) behavior (#49462)

commit 12ebf5d03e16c417b44a8a236acc696e13c61931
Author: Aarni Koskela <akx@iki.fi>
Date:   Fri Nov 4 18:52:30 2022 +0200

    STYLE/PERF: use f-strings instead of ''.join on static elements (#49517)

    STYLE: use f-strings instead of ''.join on static elements

commit d21f19c0d4669704b00484d5993d643d5cca2e13
Author: Aarni Koskela <akx@iki.fi>
Date:   Fri Nov 4 18:50:37 2022 +0200

    STYLE: fix pylint consider-using-f-string issues (#49515)

    Refs #48855

commit 57d8d3a7cc2c4afc8746bf774b5062fa70c0f5fd
Author: ram vikram singh <ramvikrams243@gmail.com>
Date:   Fri Nov 4 15:47:35 2022 +0530

    UPGRADE: Autoupdate pre-commit config (#49428)

    * gh 94906

    gh 94906

    * fixup

    * fixup

    * pyupgrade

    * clean up

    * update

    * updates

    * fixup

    * fixup use_time in vectorized.pyx

    * fixup use_time in vectorized.pyx

    * changes

    * up1

    * up2

    * up3

    * remove duplicated line, split acc. to black formatter

    * remove added newline

    * remove misplaced commas

    Co-authored-by: MarcoGorelli <>
    Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>

commit f6204a57ef174d0058744dda1bfa3e6c67b5c639
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Thu Nov 3 23:03:19 2022 -0700

    CI: Fix ASV post str.replace(regex) change (#49512)

    Thanks @mroeschke.

commit 7b605f3033117826352e3770ec2bb1a25fcc418b
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Thu Nov 3 21:29:23 2022 +0100

    STYLE enable pylint: comparison-of-constants (#49502)

commit d49eee36271ca3cd324384b7f8294e833b50ff14
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Thu Nov 3 18:44:58 2022 +0000

    CI: fix flake8 warning (#49504)

    fix ci

    Co-authored-by: MarcoGorelli <>

commit cf3043ec449137fca3619da5405590c15a87cccc
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Nov 3 10:47:45 2022 -0700

    API: Series.astype(td64_unsupported) raise (#49290)

    * API: Series.astype(td64_unsupported) raise

    * update docs

commit 8188f6c1010fa80bbc15a152bc38e8d4eb50299a
Author: raisadz <34237447+raisadz@users.noreply.github.com>
Date:   Thu Nov 3 17:33:18 2022 +0000

    BUG: Unclear error message when merging tables and passing invalid option to validate (#49419)

    * improve the error message for invalid validate arguments

    * change error message in test_join

    * resolve merge conflict

    Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>

commit cedd1222e3b2ac60d1006bf09df4c8a4870773c5
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Nov 3 09:49:54 2022 -0700

    DEPR: __setitem__ on dt64tz with mixed timezones (#49454)

    * BUG: Series(mixed_tz_objs, dtype=dt64tz)

    * whatsnew

    * update pyi

    * DEPR: __setitem__ on dt64tz with mixed timezones

commit aebd2293b9e80893f4bc6fbf5f870be5ae8c7ce0
Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Date:   Thu Nov 3 17:36:29 2022 +0100

    TST: avoid chained assignment in tests outside of specific tests on chaining (#49474)

    * TST: avoid chained assignment in tests outside of specific tests on chaining

    * update to use .loc[index[slice], ..] pattern

commit b77417832c76f0027723cad68ffd5654bbafe2a9
Author: Bill <35750915+roadswitcher@users.noreply.github.com>
Date:   Thu Nov 3 12:32:05 2022 -0400

    STYLE: enable pylint warnings for `cell-var-from-loop` (#49445)

    * STYLE: Refactored one loop, suppressed three false positives.

    * Oooh, didn't think of that.

    * I need to get better at spotting this stuff.

    * Yeah, let's not suppress those after all.

    * Accidentally removed a newline.

    * Helps to revert to correct version of file.

    * OK, backing slowly away from the git client now.

    * OK, backing slowly away from the git client now.

    * Resolve autotyper find

    * Added type hints per reviewer note.

    * Update pandas/core/strings/object_array.py

    Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>

    * Update pandas/tests/io/parser/test_c_parser_only.py

    Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>

    Co-authored-by: William Blum <william.blum@altamiracorp.com>
    Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>

commit 48df4276496d588502643fedf6d617d5e635f519
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Thu Nov 3 17:30:45 2022 +0100

    enable pylint: consider-using-sys-exit (#49480)

commit 050a1a2e22bf383a3acef9dbbb5a0c3dbc6948b0
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Thu Nov 3 09:27:12 2022 -0700

    DEPR: Change str.replace(regex) from True to False & single behavior (#49486)

    * DEPR: Change str.replace(regex) from True to False & single behavior

    * Add versionnchanged

commit 133c6ddb8b0d29571a4dcfff515dee83bc46fb55
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Thu Nov 3 09:25:32 2022 -0700

    DEPR: HDFStore.iteritems, read_csv(use_cols) behavior (#49483)

    * Remove HDFStore iteritems

    * Enforce use_cols deprecation in read_csv

    * Spelling

commit d9f98f8c4c32cc9c702afc7f91fbc8bd24e673a1
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Nov 3 09:14:58 2022 -0700

    DEPR: Index methods, to_time, Categorical constructor (#49457)

    * DEPR: Index methods, to_time, Categorical constructor

    * update doc

    * Update doc/source/whatsnew/v2.0.0.rst

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

commit ad76a3a77c9b733a185686ee4c4f7ad9631a0f7c
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Thu Nov 3 09:09:17 2022 -0700

    API/BUG: Fix is_string_dtype and make more strict (#49378)

    * fix extension tests

    * Make is_string_dtype more strict

    * Simplify and add example

    * get dtype

    * Catch cased when TypeError is raised

    * Change

commit 6f97335727cfe85cdb22ad3a42507cefa470299b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Nov 3 11:02:26 2022 -0400

    more verbosity

commit 19157f0718dbfe639f7bd01e196f0f64a95b1180
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Nov 3 10:52:35 2022 -0400

    adjust

commit d7ddd871c5380f2ab0fcf6080e6dd6124ff59331
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Nov 3 10:39:41 2022 -0400

    Try cd'ing into the doc directory

commit c0625568ce70e85974d3b6ba91f78c329d6e40d5
Author: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Date:   Thu Nov 3 15:35:55 2022 +0100

    DEP: Enforce deprecations of read_csv keywords (#48849)

commit 35a81353dc3ede91b251be9e66d3b21965c24b61
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Nov 3 07:35:19 2022 -0700

    Bump matplotlib min_ver to 3.6.1 (from 3.6.0) (#49491)

    Bump matplotlib min_ver to 3.6.1

commit a215264d472e79c48433fa3a04fa492abc41e38d
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Nov 3 01:32:47 2022 -0700

    DEPR: Index.reindex with non-unique Index (#49485)

commit e02133c6323ddfd886784d6a9d3a4e5c07c99557
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Thu Nov 3 01:25:19 2022 -0700

    CI: Remove GHA running on 1.4.x branch (#49488)

commit 7ccac683c074aaf5abaedd64f8aa5da4d9fe08ee
Author: stellalin7 <linstel@gmail.com>
Date:   Wed Nov 2 16:07:02 2022 -0500

    issue 48855 enable pylint C-type "disallowed-name " warning (#49379)

    * remove from exclusions + cleanup

    * try foo variation, instead

    * revert change + exclude from linting

    * revert + exclude from linting

    * revert + exclude fron linting

    * more descriptive names

    * try assigning to itself

    * more test clean-up

    * try reverting with exclusion

    * more clean-up

    * revert

commit 6526e938a0405877e57a6bf57c36d7fc77449081
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Wed Nov 2 21:00:15 2022 +0000

    CI maybe fix arm test (#49476)

    * maybe fix arm test

    * add comment linking to issue

    Co-authored-by: MarcoGorelli <>

commit 3ae895486d2abdbf8f4c015c4e348b52d7ee6dc0
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 15:30:15 2022 -0400

    debug more

commit 9820edc174730e11cb423d7869650c13100eb314
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Nov 2 11:56:50 2022 -0700

    DEPR: indexing (#49412)

    * DEPR: disallow Series.__getitem__ with a single-element list containing slice

    * DEPR: disallow slicing with positional slicer and .loc

    * DEPR: disallow positional indexing with float key

    * move whatsnew

    * DEPR: disallow multi-dimensional indexing

    * fix matplotlib tests

    * update install.rst

commit e5961e2dcb9b8b84853c32ad4d1f6fb7d6f84454
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Nov 2 11:53:35 2022 -0700

    API: make some Timestamp args keyword-only (#49416)

    * API: make some Timestamp args keyword-only

    * mypy fixup

    * docstring arg order

commit cdc8db6e0d3394e0aabbaf0740ab06e34bf67aa8
Author: Luke Manley <lukemanley@gmail.com>
Date:   Wed Nov 2 14:51:55 2022 -0400

    DEPR: inplace argument in set_axis (#49459)

    * enforce deprecation of inplace argument in set_axis

    * default copy to True

commit 53430f2299291ec7cd0c9b79bc68b2c9f3730598
Author: Shoham Debnath <debnathshoham@gmail.com>
Date:   Thu Nov 3 00:13:52 2022 +0530

    BUG: pivot_table with margins=T raises when results in empty df (#49438)

    * BUG: pivot_table with margins=T raises when results in empty df

    * suggested change

    * suggested change

    * Update pivot.py

    * linked test to issue

    * suggested edit

commit 75d093dae92a68e6f979815ce131036055492d39
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Nov 2 11:25:39 2022 -0700

    DEPR: DatetimeIndex setops with mismatched tzs (#49455)

commit 72688c78dfa5519b8f3587f3664178a60daa2605
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Nov 2 11:15:32 2022 -0700

    DEPR: Index(ndarray[object]) inferring numeric dtype (#49458)

commit 645b499f39115dac63e254d711acaf05c07669ac
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Nov 2 11:07:10 2022 -0700

    DEPR: Disallow kwargs in ExcelWriter (#49463)

commit f43d3a77d284adca8daddcb705ede1907de48eb6
Author: Thierry Moisan <thierry.moisan@gmail.com>
Date:   Wed Nov 2 14:06:34 2022 -0400

    STYLE: fix pylint no-else-continue warnings (#49464)

commit 4c0f3f66a32381b0992b73e7455a260173529c43
Author: Bill <35750915+roadswitcher@users.noreply.github.com>
Date:   Wed Nov 2 13:26:54 2022 -0400

    STYLE Suppressing two instances of pylint W0703 broad-except.  (#49470)

    * Suppressing two instances of pylint W0703 broad-except.   32 more to check.

    * Ran pre-commit, fixed spacing.

commit c0dac691b8a969a58246d96874622ed34f3216f1
Author: Luke Manley <lukemanley@gmail.com>
Date:   Wed Nov 2 13:23:30 2022 -0400

    DEPR: enforce passing non boolean sort in concat (#49472)

    enforce deprecation non boolean sort in concat

commit 3f985b913625c6b1fa15a03dfb986ab4fc1a7ee7
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Nov 2 09:36:49 2022 -0700

    CLN: assorted; silence test warnings (#49426)

    * CLN: assorted

    * revert

    * fix warning suppression

commit cd1af81387784cce25cc8ae0813ac02ac58c3b8a
Author: Bill <35750915+roadswitcher@users.noreply.github.com>
Date:   Wed Nov 2 12:29:34 2022 -0400

    BUG: Return type discrepancy in USFederalHolidayCalendar (#49118)

    * GH49075 looks weird.   Let's add a test and go from there.

    * Some cleanup.

    * First pass at the fix.

    * Missed a space, failed formatting check.

    * pre-commit would have caught that, eh.

    * Update test_federal.py

    * Well, that was subtle.

    * Changed the test.

    * Git mistake.

    * Backing away from keyboard now.

    * next: write more tests.

    * precommit local run.

    * User specified half-open date intervals can return inconsistent results.

    * Added logic to close open time intervals into AbstractHolidayCalender

    * OK, I've learned pre-commit doesn't pass wildcards all the way down a directory tree.

    * Ensure DatetimeIndex returned in _apply_rule

    * Ensure DatetimeIndex returned in _apply_rule

    * Caught formatting.

    * Missed running isort locally.

    * Well, that was subtle.

    * Changed URL to current OPM source-of-record, updated whatsnew

    * Update v2.0.0.rst

    * Add dtype to empty index ( caught by mypy in CI, not part of pre-commit )

    * Updated holiday.py

    * ... and forgot to pre-commit run black

    * Update pandas/tseries/holiday.py

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

    * Update v2.0.0.rst

    * Added test to test_federal.py to ensure comparison against known-good result in addition to type comparison

    * Add change to test_federal to compare against constructed DatetimeIndex, cleaned up test_half_open_interval_with_observance() in test_holiday.

    * Update doc/source/whatsnew/v2.0.0.rst

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

commit 7ca8ef9b9bbd2b9a3acfec6d5df77d778c0a7fa9
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 10:35:28 2022 -0400

    typoed

commit 490c5d049890d8ea71ec5e2dc4ffa6196c10cc63
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Nov 2 07:18:09 2022 -0700

    DEPR: Remove check_less_precise in asserters (#49461)

commit 1766cf900ec2a09e32156702a4485804018017bd
Merge: 4ce0be46bc cdf560596d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 10:07:14 2022 -0400

    Merge branch 'meson-poc' of github.com:lithomas1/pandas into meson-poc

commit 4ce0be46bcc3c4497a93ac817c78d7441784bdaa
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 10:07:01 2022 -0400

    debug docs

commit cdf560596dd5d79478a1a42fc0dc9a9e162e876d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 09:00:46 2022 -0400

    update meson-python repo

commit 29184cbe991bebeac6f1708a6624ddab82e1fad0
Merge: 0397b46bb1 a62ee23e0b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 09:00:19 2022 -0400

    Merge branch 'meson-poc' of github.com:lithomas1/pandas into meson-poc

commit 0397b46bb1c08b4afddfdd256cf8b76d25ed41ab
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 09:00:04 2022 -0400

    try to fix docs

commit a62ee23e0b65938ea902eee8d85c5a395e291c75
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 06:46:00 2022 -0400

    adjust build to account for deprecations

commit 7bf8d6b318e0b385802e181ace3432ae73cbf79b
Author: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>
Date:   Wed Nov 2 20:41:50 2022 +1000

    (🎁) add python 3.11 to sdist.yml (#49460)

    add python 3.11 to sdist.yml

    Co-authored-by: KotlinIsland <kotlinisland@users.noreply.github.com>

commit 524e4938944099c16c632837dd5a8f7db5bae9b4
Merge: bfcb9d04c4 dec9be2a5c
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Nov 2 06:39:34 2022 -0400

    Merge branch 'main' into meson-poc

commit dec9be2a5c6f34f13597a4089d4d48d09ef6ea6f
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Wed Nov 2 10:04:49 2022 +0100

    enable pylint: literal-comparison (#49447)

    * enable pylint: literal-comparison

    * enable pylint: no-self-use

    * enable pylint: invalid-sequence-index

commit a793802ca08ba159558e36db95f8242fb0f44156
Author: Mark Harfouche <mark.harfouche@gmail.com>
Date:   Tue Nov 1 21:02:17 2022 -0400

    Make the conversion from dtype to subclass just a little faster (#49393)

    Use kind to speed up dtype decision

commit 4e7ade7d3e50e2b04d2f9150b59cf6f2d1fefd6d
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Nov 1 17:53:41 2022 -0700

    DEPR: DTA(float_data, dtype=dt64tz) (#49361)

    DEPR: DTA.astype unitless, DTA(float_data, dtype=dt64tz)

commit fb9b3451c4f70818604bd7afb7bbdd4c04d12667
Author: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
Date:   Tue Nov 1 20:46:30 2022 -0400

    DEPR: Enforce deprecation of silent dropping of nuisance columns in agg_list_like (#49401)

    * DEPR: Enforce deprecation of silent dropping of nuisance columns in agg_list_like

    * Remove type-ignore

    * Fixups

    * Remove outdated comment

commit cb43a819d8e34f61ecb4121d154b1f9a9357eaea
Author: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
Date:   Tue Nov 1 20:42:58 2022 -0400

    CLN: Remove xlrd < 2.0 code (#49376)

    * CLN: Remove xlrd < 2.0 code

    * Add test

    * Add warning

    * Fix type-hint

    * Update pandas/io/excel/_xlrd.py

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

    * Remove warning

    * Remove warnings in tests

    * Remove filter

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

commit c0445543a10ae6c6abe5a3efc519fd9edcd2d276
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Nov 1 16:20:35 2022 -0700

    API: Series([pydate, pydatetime]) (#49446)

commit 65badbf3100c1dec4f43f0cead5ef00807921e97
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Nov 1 15:53:41 2022 -0700

    DEPR: Timestamp(dt64obj, tz=tz) (#49381)

commit aae800d988bcb6ce8c49dfa9c4f9f61d265dd937
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Nov 1 15:51:56 2022 -0700

    DEPR: internals (#49392)

    * DEPR: internals

    * bump fastparquet minimum

commit 67a61358744eeea472c4cbf261d6ef18ff8a18f4
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Tue Nov 1 15:39:37 2022 -0700

    DEPR: Enforce disallowed merging scenarios (#49429)

    * Enforce merge suffixes tuples

    * Duplicate merge columns

    * enforce disallowing different levels

    * Fix test

commit b858de02798dc777fe2dd2bf261c9e037c74a4a9
Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Date:   Tue Nov 1 20:46:43 2022 +0100

    BUG: CoW - correctly track references for chained operations (#48996)

    Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>

commit b3bd5ad380d871cac18738853906fc76cc865c54
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Nov 1 11:45:09 2022 -0700

    DEPR: SparseArray.astype (#49324)

    * DEPR: SparseArray.astype

    * fix append test

    * remove no-longer-overriden tests

commit c4a24d29bc47a673a3d84980c8d9a8a9040dc076
Author: Zachary Moon <zmoon92@gmail.com>
Date:   Tue Nov 1 12:38:00 2022 -0600

    BUG: Fix passing `Colormap` instance to plot methods with mpl >= 3.6 (#49377)

    * Create failing test for passing Colormap inst

    to `.plot.scatter`

    * Use `mpl.colormaps.get_cmap`

    when a Colormap instance might be passed

    * Test hexbin too

    * Add whatsnew

commit 6122c7de128fce3a84d91ef91b9dc3a914531745
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Nov 1 10:40:28 2022 -0700

    DEPR: non-keyword args, errors arg (#49415)

    * DEPR: non-keyword args, errors arg

    * Update doc/source/whatsnew/v2.0.0.rst

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

commit 76923d7b58d8f25329e779a40b87e2b6959f9cea
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Tue Nov 1 15:54:19 2022 +0100

    issue 48855 enable pylint unnecessary-pass (#49418)

    issue 48855 enable unnecessary-pass

commit e6ce78dae8e1e60ed025c0700f501471378b972c
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Tue Nov 1 07:49:24 2022 -0700

    DEPR: Remove df.info(null_counts=) (#49430)

commit eec47a1ebe57a31480125e2328b33f12be865d0b
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Tue Nov 1 07:48:06 2022 -0700

    TST: Remove unnecessary pytest fixture scopes (#49424)

commit c9fc7fc662a4f2d821f7f9abfa2cf5c1429a85f9
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Tue Nov 1 07:47:06 2022 -0700

    CLN: test_expressions.py (#49422)

commit 83798f69eb1c0ee7c1a94109e6df9a00bbd31730
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Tue Nov 1 14:06:25 2022 +0000

    CI: maybe fix docs build (#49437)

    fix scipy link

    Co-authored-by: MarcoGorelli <>

commit 46cb18c4a021f5058f9018aa9c3106cfc7914aa7
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Tue Nov 1 13:10:16 2022 +0100

    enable pylint unused-wildcard-import (#49425)

commit 73483be93ffdd2d826e18e782dbed386cdb2d9c7
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Tue Nov 1 13:09:12 2022 +0100

    enable pylint wildcard-import (#49427)

commit eb69d8943fdc2b551f083435a184b7899ad13548
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Mon Oct 31 14:48:19 2022 -0700

    DEPR: Timestamp comparison with pydate (#49394)

commit 60013a26634b581e34d967f76907de460b9adb93
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Mon Oct 31 14:46:53 2022 -0700

    DEPR: Enforce empty Series returning object dtype (#49342)

    * DEPR: Enforce empty Series returning object dtype

    * Fix some tests & simplify

    * only for list like types

    * len(data)

commit ead5c756da231d971cde0627e88acb4b51588568
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Mon Oct 31 12:17:59 2022 -0700

    DEPR: Remove datetime_is_numeric in describe (#49368)

    * DEPR: Remove datetime_is_numeric in describe

    * Simplify

commit cb57af0efaa87fe9198d0cf5ec3e0010140cd398
Author: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>
Date:   Tue Nov 1 04:50:48 2022 +1000

    (📚) update docs to mention 3.11 support (#49320)

    update docs to mention 3.11 support

    Co-authored-by: KotlinIsland <kotlinisland@users.noreply.github.com>

commit 278c69bca0b0480b9d33d6b9849106aad33daf3c
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Mon Oct 31 11:47:34 2022 -0700

    API: stop silently ignoring parsing failures with dtype=dt64 (#49358)

commit 321157d2ff96433eb9381f556575ee6e0b97a3c4
Author: Shoham Debnath <debnathshoham@gmail.com>
Date:   Mon Oct 31 23:47:11 2022 +0530

    asv groupby.string smaller_faster (#49385)

commit 768346b7a566beb87b17741ca81bc9383ec5ed84
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Mon Oct 31 11:13:35 2022 -0700

    DEPR: disallow unit-less dt64 dtype in astype (#49391)

commit cc2aa48b6e6363ddbaa9d2d875af8faf76aa1ea5
Author: JHM Darbyshire <24256554+attack68@users.noreply.github.com>
Date:   Mon Oct 31 18:49:34 2022 +0100

    DEPR: remove 1.0 deprecations in 2.0 (`Styler`) (#49397)

    * styler deprecations cleaned up

    * styler deprecations cleaned up

    * styler deprecations cleaned up

    * whats new added

    Co-authored-by: JHM Darbyshire (iMac) <attack68@users.noreply.github.com>

commit 735c6b08b57d5178b563e6c731387c5c9ef74e98
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Mon Oct 31 18:44:23 2022 +0100

    enable pylint:useless-return (#49400)

    * enable pylint:useless-return

    * fixup! enable pylint:useless-return

    Co-authored-by: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>

commit 0f8d9bfb96abb197764d7696826a48da03d92819
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Mon Oct 31 10:35:23 2022 -0700

    DEPR: core.index file (#49403)

commit bf7cdf15b629e725a793f4b8fdb0375ce083a98e
Author: Pedro Nacht <pedro.k.night@gmail.com>
Date:   Mon Oct 31 14:34:18 2022 -0300

    Fix Scorecards GitHub Action (#49410)

    Bump ossf/scorecard-action to 2.0.6

    Fixes unexpected breaking change in upstream API.

commit d2f376bc99cf1bad9308fbe0dcdf78df071bc55c
Author: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Date:   Mon Oct 31 18:13:27 2022 +0100

    REGR: Fix regression RecursionError when replacing numeric scalar with None (#48234)

    * REGR: Fix regression RecursionError when replacing numeric scalar with None

    * Update

    * Restore 1.4.x behavior

    * Fix mypy

    * Move whatsnew

commit c45bc9a7b8b76324499ac52c957f3ee59c983342
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Mon Oct 31 18:05:57 2022 +0100

    STYLE: enable pylint nan-comparison (#49407)

commit 3872572512b4ea5af50618203331d9c7cc5d5fd8
Author: silviaovo <111673781+silviaovo@users.noreply.github.com>
Date:   Mon Oct 31 22:35:02 2022 +0800

    DOC: add name parameter to the IntervalIndex for #48911 (#49386)

    * DOC: fix #48911, add name parameter to the IntervalIndex

    * DOC: fix #48911, add name parameter to the IntervalIndex

commit 3370c8179de16b3f0556891a1ff06131e186dfd1
Author: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
Date:   Sun Oct 30 12:18:20 2022 -0400

    DEPR: Enforce deprecation of partial failure in transform for lists/dicts (#49375)

    * DEPR: Enforce deprecation of partial failure in transform for lists and dicts

    * Warning message fix

    * Cleaner msgs

commit 4b98e0b99ad3064463f9dc777e46d0b2f249e248
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Sun Oct 30 05:21:09 2022 -0700

    DEPR: DataFrame.median/mean with numeric_only=None and dt64 columns (#49250)

commit 7b393290f814e60a5fbecf4fce5e1ca2bd862201
Author: Vamsi Verma <40605798+vamsi-verma-s@users.noreply.github.com>
Date:   Sun Oct 30 13:27:55 2022 +0530

    DEP: remove deprecated loffset and base args for resample and Grouper (#49101)

    * pylint: disable access-member-before-definition for loffset

    * remove deprecated loffset and base args

    * fix docstring for resample

    * change date_range import to avoid flake8 warning

    * fix resample test_depecerated imports

    * move change note to deprecation section

    * remove all deprecated tests for resample

commit d97e7bed65b1389ad669f7b8d028f603e8760f2a
Author: Marco Edward Gorelli <33491632+MarcoGorelli@users.noreply.github.com>
Date:   Sat Oct 29 18:50:53 2022 +0100

    ENH Guess %Y-%m format (#49389)

    guess %Y-%m format

    Co-authored-by: MarcoGorelli <>

commit 2c86d9f472f61226df429cb6f80495771aaa789d
Author: Luke Manley <lukemanley@gmail.com>
Date:   Sat Oct 29 13:11:13 2022 -0400

    DOC: add missing whatsnew for #49321 (#49383)

    whatsnew

commit 8d615a34f2d462cb21714a0cc577849960fc83b7
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Sat Oct 29 09:51:50 2022 -0700

    DEPR: Remove week & weekofyear for datetimes (#49380)

commit ab6562a20bd894d02fb28675809698d5be0436f9
Author: Luke Manley <lukemanley@gmail.com>
Date:   Fri Oct 28 21:42:20 2022 -0400

    DEPR: remove inplace arg in Categorical methods (#49321)

    * deprecate inplace arg in categorical methods

    * fix tests

    * add back test

    * doc fix

    * doc fixes

    * avoid constructing new objects on every iteration

    * cleanup

commit 8ea52bb32a5a0956467b3532e6c2ac704c8b90e2
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Fri Oct 28 16:16:55 2022 -0700

    DEPR: Enforce disallowing loc with positionals (#49345)

    * DEPR: Enforce disallowing loc with positionals

    * Fix asv usage

    * Trigger CI

commit f9ff3796329e4bedb4a5477739f5eb8d2e40761d
Author: Carlotta Fabian <73344238+fabinca@users.noreply.github.com>
Date:   Fri Oct 28 20:52:42 2022 +0200

    STYLE fix: pylint "consider-using-from" (#49335)

    * use from import

    * delete empty file

    Co-authored-by: carlotta <c.fabian@turbit.de>
    Co-authored-by: cfabian <cfabian@student.42wolfsburg.de>

commit 17e0e0642294acecef2d2909801758e1785bd701
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Oct 28 11:35:57 2022 -0700

    DEPR: non-keyword arguments (#49359)

    * DEPR: non-keyword arguments

    * fix asv

commit 1506ed559e14f7c8ddb24e623e27b07c97b2a197
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Oct 28 11:27:42 2022 -0700

    DEPR: disallow int fill_value in shift with dt64/td64 (#49362)

commit f1bb3b2a3ca65779baa732a86853227936b4404e
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Fri Oct 28 09:47:50 2022 -0700

    DEPR: object-dtype bool_only (#49371)

commit 0a5cb8f47712fec6009d0f0e3eaf5ef924b5fc57
Author: carla-alves-24 <112690333+carla-alves-24@users.noreply.github.com>
Date:   Fri Oct 28 18:31:24 2022 +0200

    DOC: update query/eval figures on performance comparison  (#48368)

    Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

commit 3020b8df58927ef0246091d325debce7097ace60
Author: Thierry Moisan <thierry.moisan@gmail.com>
Date:   Fri Oct 28 10:21:23 2022 -0400

    STYLE: fix pylint use-maxsplit-arg warning (#49369)

commit cb42e052416d0d0f33ff8ba9bdbaf8bfa383c15b
Author: sarvaSanjay <111774640+sarvaSanjay@users.noreply.github.com>
Date:   Fri Oct 28 09:19:13 2022 -0400

     DOC: Removed line about %S parses all the way up to nanosecond even if no (#49349)

    * Removed line about %S parses all the way up to nanosecond even if no decimal place present from docstring

    * Deleted example code and changed documentation to though note that %f will parse all the way up to nanoseconds

    * Fixed CI error

    * Changed  to %f

    * Removed line between format and exact

    * removed whitespace at end of line

    * Re-added formatting to %f

commit a393c98f0cc1f7985ed89229bfa107ebbc723157
Author: Hatim Zahid <63000127+HatimZ@users.noreply.github.com>
Date:   Fri Oct 28 06:18:19 2022 -0700

    DOC: Added pre-commit link inside the guideline for developers. (#49308)

    * Added pre-commit link inside the guideline

    * Updated the Text to install pre-commit hooks.

    * Changed the https link to short form link.

    * Added a period at the end of the sentence

    * Changed location of pre-commit text and made it optional.

commit 8564b701454c0cdd443b0a786f291e04b4f05359
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Oct 27 20:36:40 2022 -0700

    DEPR: to_datetime('now') match Timestamp('now') (#49346)

    * DEPR: to_datetime('now') match Timestamp('now')

    * perf

    * try again

commit 30589f72a2c8cfbe4cd4e4d78161c18adca46212
Author: Terji Petersen <contribute@tensortable.com>
Date:   Thu Oct 27 17:37:18 2022 +0100

    CLN: Index._hidden_attrs (#49299)

    * CLN: Ibdex._hidden_attrs

    * CLN: black fixes

    Co-authored-by: Terji Petersen <terjipetersen@Terjis-MacBook-Air.local>
    Co-authored-by: Terji Petersen <terjipetersen@Terjis-Air.fritz.box>

commit b74bf147f00dccda2165f0c36506ac946b2e6948
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Oct 27 09:25:57 2022 -0700

    REF: simplify maybe_infer_to_datetimelike (#49344)

    * REF: simplify maybe_infer_to_datetimelike

    * simplify sequence_to_datetimes

commit 6b4fa02e10480c4ddae0714e36b7fe765fa42eac
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Thu Oct 27 09:23:52 2022 -0700

    REF: simplify sanitize_array (#49347)

    REF: simpify sanitize_array

commit bcb8346e8106be4267ec77dfc603d0d77a3fda81
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Thu Oct 27 09:10:05 2022 -0700

    DEPR: Remove xlwt (#49296)

    * DEPR: Remove xlwt

    * Remove another ref to option

    * Adjust tests

    * Just remove xls benchmark

    * Fix some tests

commit 05fb08ecca8850b71f659788183b48db9bc4e391
Author: Madhuri Patil <60868865+madhuri-15@users.noreply.github.com>
Date:   Thu Oct 27 20:44:00 2022 +0530

    Fixed broken link (#49351)

commit b48735a6b025f99f4b03713e894003080df595bb
Author: Carlotta Fabian <73344238+fabinca@users.noreply.github.com>
Date:   Thu Oct 27 11:27:58 2022 +0200

    STYLE: fix pylint consider-using-get warnings (#49334)

    resolved this pylint error

    Co-authored-by: carlotta <c.fabian@turbit.de>

commit db1b45816d0871f75d90f9449757176573cbfec9
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Oct 26 17:09:07 2022 -0700

    DEPR: Enforce diallowing indexing with single item slice (#49343)

commit 201cac4c6a43496a31cb1156cad9bfea47eaeb60
Author: Thierry Moisan <thierry.moisan@gmail.com>
Date:   Wed Oct 26 18:38:58 2022 -0400

    STYLE: fix pylint simplifiable-if-expression warnings (#49339)

commit 2c775676b7f9facbd27fe6495599b7ef60f98c04
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Oct 26 13:34:00 2022 -0700

    DEPR: DataFrame dtype keyword match Series behavior (#49313)

commit 9c9789c515f79d1a065ca6891464865d3cd16468
Author: Adam Mróz <505546+a-mroz@users.noreply.github.com>
Date:   Wed Oct 26 21:06:57 2022 +0200

    Improve error message about duplicate columns in df.explode (#49264)

commit 2317bf08ed172048a66a0533645ebc1886939417
Author: William Ayd <will_ayd@innobi.io>
Date:   Wed Oct 26 10:58:09 2022 -0700

    Vendored klib quadatric probing (#49197)

    Vendored klib quadtric probing

commit 7fddb30c82d70ef72fce6634bc26d1ab71312356
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Oct 26 10:46:28 2022 -0700

    DEPR: non-keyword arguments (#49302)

    * DEPR: non-keyword arguments

    * Update doc/source/whatsnew/v2.0.0.rst

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

commit 032316f631b4c29a3b1ddc266ea667dfa39aadcd
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Oct 26 10:42:34 2022 -0700

    DEPR: disallow subclass-specific keywords in Index.__new__ (#49311)

commit 3288d8ff5652e7a020df167755a8066561304948
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Oct 26 10:29:28 2022 -0700

    DEPR: Remove SparseDataFrame/Series pickle compat (#49316)

    * DEPR: Remove SparseDataFrame/Series pickle compat

    * Add to whatsnew

commit 6ee0acb936d17f6006048f840710bbecf2616f84
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Wed Oct 26 10:00:02 2022 -0700

    DEPR: stop inferring dt64/td64 from strings in Series construtor (#49319)

    * DEPR: stop inferring dt64/td64 from strings in Series construtor

    * update pyi

commit 218ab0930e477337ece6c46d497c14d447352d8a
Author: Natalia Mokeeva <91160475+natmokval@users.noreply.github.com>
Date:   Wed Oct 26 17:56:21 2022 +0200

    update from_dict docstring (#49332)

commit 76fc83a886e6ed64cb66d97b34e5a4170850d92f
Author: minat-hub <68482010+minat-hub@users.noreply.github.com>
Date:   Wed Oct 26 16:49:06 2022 +0100

    DOC: Updates to documentation (#49278)

    * issue #48674 index constructor updates to the frame.py file

    * remove pandas-env in gitignore file and print from frame.py

    * remove blank line before closing docstring

    * reduce character count in changes made

commit 681dd2d35a6baf13a74a5a00ec1a74935d4e7bc6
Author: Thierry Moisan <thierry.moisan@gmail.com>
Date:   Wed Oct 26 09:00:36 2022 -0400

    STYLE: fix pylint simplifiable-if-statement warnings (#49323)

    * STYLE: fix pylint simplifiable-if-statement warnings

    * fixup! STYLE: fix pylint simplifiable-if-statement warnings

commit 1e5fee83f914db3775d931cbe289bcb2288531d0
Author: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Date:   Wed Oct 26 11:40:17 2022 +0200

    CI: Catch FutureWarnings (#49287)

commit c0b180014bcd6b51891057e4711b18351509ca3d
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Oct 26 02:35:06 2022 -0700

    DEPR: Remove get_offset, infer_freq warn param (#49314)

commit 5d9090b1a09dfae767dd41a4e8ba020cc9e07418
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Oct 26 02:34:00 2022 -0700

    DEPR: Disallow groupby __getitem__ with tuple (#49317)

commit 62757c43ba506c62edeed300def524d6071dd79b
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Wed Oct 26 02:33:09 2022 -0700

    DEPR: Remove sort_columns in plotting (#49315)

commit eef20d32724e90d3a02b39798737f487913f1669
Author: Xnot <28331593+Xnot@users.noreply.github.com>
Date:   Wed Oct 26 04:25:14 2022 -0300

    DOC: Fix typo in DataFrame.rolling (#49322)

commit bca35ff73f101b29106111703021fccc8781be7a
Author: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Date:   Tue Oct 25 23:07:43 2022 +0200

    DEP: Enforce fname to path renaming (#49288)

commit 0d95478c738afe96e78b66966edde490362ecf49
Author: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Date:   Tue Oct 25 14:02:35 2022 -0700

    DEPR Enforce ewm.vol deprecation (#48841)

commit a7341b37a53f121262c07f373c4552b69673d25b
Author: Thierry Moisan <thierry.moisan@gmail.com>
Date:   Tue Oct 25 16:00:11 2022 -0400

    STYLE: fix pylint consider-iterating-dictionary warnings (#49305)

commit 74c4cd1f25b81bb0e5afc70d063c785565fde7fd
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Oct 25 11:37:31 2022 -0700

    DEPR: Series(dt64_naive, dtype=dt64tz) (#49242)

    * DEPR: Series(dt64_naive, dtype=dt64tz)

    * mypy fixup

commit 6a1ae42bca296f8f1cf649e466dc8e11536a079f
Author: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Date:   Tue Oct 25 20:35:03 2022 +0200

    DEP: Disallow abbreviations for orient in to_dict (#49289)

    * DEP: Disallow abbreviations for orient in to_dict

    * Update pandas/tests/frame/methods/test_to_dict.py

    Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

commit 3a04668132a1e0299eb087730717d5ca15e4aec4
Author: Luke Manley <lukemanley@gmail.com>
Date:   Tue Oct 25 14:33:20 2022 -0400

    DEPR: inplace arg in Categorical.remove_unused_categories (#49300)

    deprecate Categorical.remove_unused_categories

commit 448f38c5ef976c122fbff0363462fd68a9794fc6
Author: jbrockmendel <jbrockmendel@gmail.com>
Date:   Tue Oct 25 11:29:05 2022 -0700

    DEPR: store SparseArray directly in Index (#49307)

commit 71558d91c2834540a9aab3ba0f827930f0e3633f
Author: Torsten Wörtwein <twoertwein@users.noreply.github.com>
Date:   Tue Oct 25 13:57:44 2022 -0400

    TYP: fix ReadPickleBuffer (#48144)

    * TYP: fix ReadPickleBuffer

    * require fileno only for ReadCsvBuffer

    * fix comment

    * bump pyright

    * pyright

commit bfcb9d04c4bb67a74afd50cf1f279c30f0525ba8
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Oct 22 13:09:03 2022 -0400

    Update

commit f3a941902e0e90cf79b9043c1bab8c769df2fc97
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Oct 20 07:23:38 2022 -0400

    fix circleci and maybe fix docs

commit 3983e1c1f178d324cafd17129ba7a711b2114042
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Oct 19 14:43:46 2022 -0400

    Fix everything else?

commit 15e2cd0f3274dcc6271b67a8757371c4d99a9e1b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Oct 19 13:49:27 2022 -0400

    Pull upstreamed changes

commit d4da54b27d70971240b9a986ccaaeb44e06c606d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Oct 18 16:29:41 2022 -0400

    Update for sas byteswap module

commit 9a943316be55b0136ecd4f6ae21f84e0d9037c39
Merge: 588527f428 90b4add778
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Oct 15 11:43:15 2022 -0400

    Merge remote-tracking branch 'upstream/main' into meson-poc

commit 588527f428b803e6a87313772e20111ae8f55dbe
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Oct 15 09:17:49 2022 -0400

    Finally fix?

commit e61ef35ef8579c20a72f274887b2377b12866b9e
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Oct 15 07:37:54 2022 -0400

    fix version generation for sdists

commit a286e66113c7de377da032715033858df09a8622
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Fri Oct 14 16:39:36 2022 -0400

    maybe fix?

commit c01409c2c3dbda7e88d97445dfa46dd5bdea5255
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Fri Oct 14 07:45:20 2022 -0400

    try to fix coverage

commit 3c5ae9439299fa9ae54d5c7c49e40ef1b4cdadc4
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Oct 13 20:56:40 2022 -0400

    green?

commit a15586a4865d7e5683d122b756ff61a3c3d1bf91
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Oct 4 16:09:49 2022 -0400

    fix show_versions

commit 25178d5decde2688223d1f685f68f78e4cd1f548
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Oct 3 13:38:41 2022 -0400

    hopefully get versionning working, other than the sdist case

commit 5b4dddcb72c4a911f2109d698f7ca253fdb6eda0
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Oct 3 10:41:54 2022 -0400

    fix version string

commit da09ba00187789038ee03bcff7b890a26e3c0b1d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Oct 3 10:27:37 2022 -0400

    keep using versioneer

commit b49f4c52c0ec2d707d23a00dedb9ae5735081b0b
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 20:15:05 2022 -0400

    maybe fix sas module export name?

commit 883fca7634e30aff001534444b4890223241b676
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 17:11:16 2022 -0400

    use my fork of meson as well

commit 6efabb1931ae71edd952e47053ff9eb870a0b755
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 16:15:50 2022 -0400

    hardcode version, fix windows?

commit 4c0d93c354ff7d9ad49283cfcf76c0a65718a6a5
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 14:37:50 2022 -0400

    maybe fix?

commit 94ccae2e41fa157f0684d9f26932ad8b055f0ffd
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 11:14:26 2022 -0400

    try to fix windows again

commit eb41668aa0b3a27a4243b7209d4f43d843e40aef
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 08:34:14 2022 -0400

    disable caching for now

commit deb9305e38ba1e5f55e37cee7d36ca5907d09435
Merge: 039123fe63 5763023785
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sat Sep 24 07:22:17 2022 -0400

    Merge branch 'pandas-dev:main' into meson-poc

commit 039123fe63c05afa1f36fe24a242abd0077664ec
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Sep 22 11:00:37 2022 -0400

    maybe fix?

commit 9b83eff600a1f9aca988f9f009b31ca003a83125
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Sep 22 10:30:38 2022 -0400

    maybe fix windows?

commit 48b02d425f4be53a1929e802134853db0bfbd133
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Sep 22 10:13:34 2022 -0400

    try something

commit 5f0a17534137f0cfb526d47b2f04305c81ca6218
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Sep 22 09:11:28 2022 -0400

    fix msvc detection?

commit 89c4b6b978979bdd6f3279685db55d19e8ea791a
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Sep 21 10:55:45 2022 -0400

    add required shell

commit 132a689e797b00d88ac1d1556658e5b8027713f7
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Wed Sep 21 10:48:57 2022 -0400

    update

commit 30e11c67121ad36a0598f98fbaa061bea8dff367
Merge: 47f21d7fe6 73d15a7632
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Sep 20 17:52:21 2022 -0400

    Merge remote-tracking branch 'upstream/main' into meson-poc

commit 47f21d7fe60a80bf5918d38b368381091d599aa6
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Sep 20 17:50:54 2022 -0400

    build in verbose mode

commit 8f0adf2531983eec84b768dad4f8de927572f8b1
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Sep 19 17:20:01 2022 -0400

    use my meson-python fork

commit 6edad44327d8e39fb3aa910a63db75468d4a5769
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Sep 19 16:52:25 2022 -0400

    install meson-python too

commit 5e04d4efae82e772223efdbfdacbddb5a8f8b70f
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Sep 19 16:45:05 2022 -0400

    try building with pip again

commit 2751aee69d30cf04d9bfc0e49e7ca71cffc49f1d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Fri Sep 2 11:25:12 2022 -0400

    try something

commit e0214a51c3c7b885cac266aff8da47157519170e
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Fri Sep 2 11:11:34 2022 -0400

    try something

commit d074fc14cee9de1bea91cadad32f9e1feed24da6
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Sep 1 11:13:55 2022 -0400

    build pandas on CI with meson

commit 781a671af41903c05d48b3193e82da93bb55c3d2
Merge: 95e49e7c39 10855f6b55
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Sep 1 10:51:34 2022 -0400

    Merge branch 'main' of https://github.com/pandas-dev/pandas into meson-poc

commit 95e49e7c390ac79b88e59f90cdc57ecbbfa44068
Merge: 7e401dc31c e65a30e3eb
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Aug 22 15:17:26 2022 -0700

    Merge branch 'pandas-dev:main' into meson-poc

commit 7e401dc31ca155fcc7b3128ee7a7b43989c71da3
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Jul 25 15:54:06 2022 -0700

    fix all oopsies

commit 950f0a69745387f43e35b2ff11dd2fdab3f5ab88
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Jul 25 14:41:17 2022 -0700

    fix install paths

commit e70bfc69af4b274024783eed8fe2e9d7efb277f3
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Jul 25 14:04:21 2022 -0700

    remove deps usage & maybe workaround bug

commit 3df0963e1ddfb7894c937282d87a2d0b9156a024
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Sun Jul 24 11:48:45 2022 -0700

    super mega cleanup

commit 7c2c132dbf05db035dcd0407ad8548f7dccb6c7e
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Jul 19 15:42:06 2022 -0700

    clean more

commit 0eeaa7df6644bb050b67194b8191be25725df907
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Tue Jul 19 09:59:47 2022 -0700

    clean a little

commit 15e0385355f46d2a4b2107a3d0ad6adf6f21786d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Jul 18 07:27:55 2022 -0700

    build all extensions

commit 43ba9954909d262db80cb1d7f04291754507639d
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Fri Jul 15 21:12:54 2022 -0700

    compile more

commit 33a0a7cea25851a71cc0834228631f93958157dd
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Jul 14 15:05:14 2022 -0700

    [skip ci] compile more & test something

commit 6219ad05ce63de56184c5f6332fb9acc7e3e5b16
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Thu Jul 14 12:19:50 2022 -0700

    update

commit 36112effe154c54ade294eb48677dd8876f5f658
Author: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Date:   Mon Jul 11 21:46:04 2022 -0700

    WIP: Build pandas with meson
phofl pushed a commit to phofl/pandas that referenced this pull request Nov 9, 2022
@hmaarrfk @phofl
Make the conversion from dtype to subclass just a little faster (pand…
145f559 
…as-dev#49393)

Use kind to speed up dtype decision
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@hmaarrfk @noatamir
Make the conversion from dtype to subclass just a little faster (pand…
8db08da 
…as-dev#49393)

Use kind to speed up dtype decision
@phofl phofl mentioned this pull request Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Performance Memory or execution speed performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmaarrfk @jbrockmendel @mroeschke