Skip to content

ERR: Improve error message when assigning a complete row using 'at' m… #48890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 24, 2022
Merged

ERR: Improve error message when assigning a complete row using 'at' m… #48890

merged 10 commits into from
Oct 24, 2022

Conversation

ambujpawar
Copy link
Contributor

@ambujpawar ambujpawar commented Sep 30, 2022 •
edited
Loading

Better error reporting when trying to assign a new row using 'at' method

mroeschke
mroeschke reviewed Oct 3, 2022
View reviewed changes
mroeschke
mroeschke reviewed Oct 3, 2022
View reviewed changes
@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Oct 3, 2022
@ambujpawar ambujpawar requested a review from mroeschke October 8, 2022 09:38
mroeschke
mroeschke reviewed Oct 17, 2022
View reviewed changes
@mroeschke mroeschke added this to the 2.0 milestone Oct 24, 2022
@mroeschke mroeschke merged commit b44f1cd into pandas-dev:main Oct 24, 2022
@mroeschke
Copy link
Member

Thanks @ambujpawar

@jorisvandenbossche
Copy link
Member

Shall we backport this to 1.5.x?
Re-reading #48729, we started to raise the incomprehensible error in 1.5.0 (it actually worked before)

@mroeschke
Copy link
Member

Sure, makes sense to backport

@mroeschke mroeschke modified the milestones: 2.0, 1.5.2 Oct 25, 2022
@mroeschke
Copy link
Member

@meeseeksdev backport 1.5.x

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 25, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 25, 2022
@ambujpawar @meeseeksmachine
Backport PR pandas-dev#48890: ERR: Improve error message when assigni…
83f562e 
…ng a complete row using 'at' m…
phofl pushed a commit that referenced this pull request Oct 26, 2022
@meeseeksmachine @ambujpawar
Backport PR #48890 on branch 1.5.x (ERR: Improve error message when a…
ebcc47b 
…ssigning a complete row using 'at' m…) (#49310)

Backport PR #48890: ERR: Improve error message when assigning a complete row using 'at' m…

Co-authored-by: Ambuj Pawar <pawar.ambuj@gmail.com>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@ambujpawar @noatamir
ERR: Improve error message when assigning a complete row using 'at' m… (
7db132f 
pandas-dev#48890)

* ERR: Improve error message when assigning a complete row using 'at' method

* fix precommit issues

* Fix: Review comments

* Fix: precommit issues

* Raise InvalidIndexError from original exception

* Raise InvalidIndex error from original error

* fix failing tests

* fix failing tests

Co-authored-by: Ambuj Pawar <your_email@abc.example>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.at fails when setting a whole row
3 participants
@ambujpawar @mroeschke @jorisvandenbossche