BUG: histogram weights aren't dropped if NaN values in data #48888
Conversation
|
I've created a test where a df and set of weights are made, and one value in each column of df is set to NaN. I then make a copy of the df without the NaNs, and copies of weights with the corresponding weights dropped. It then checks that histograms made using each pair have the same heights. |
pandas/plotting/_matplotlib/hist.py
Outdated
| kwds["weights"] = weights[:, i] | ||
| if weights is not None: | ||
| if np.ndim(weights) != 1: | ||
| weights = weights[:, i] |
There was a problem hiding this comment.
What happens if i is out of bounds?
There was a problem hiding this comment.
This one is still open, otherwise lgtm
There was a problem hiding this comment.
@Ormorod doesn't look like this was addressed. Can i be out of bounds?
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Will merge main now. I addressed the comments above but haven't had a response. |
|
It also occurs to me that |
|
Thx @Ormorod |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.